Received: by 2002:ac0:98c7:0:0:0:0:0 with SMTP id g7-v6csp232157imd; Fri, 26 Oct 2018 07:45:26 -0700 (PDT) X-Google-Smtp-Source: AJdET5di9cPusvBwrY0ascgXTO7ZCr7cbAResUYgEYpDJywWfiHZvYA+Q8ny/E4ZduvIBVS4Cmur X-Received: by 2002:a63:b16:: with SMTP id 22mr2107289pgl.306.1540565126577; Fri, 26 Oct 2018 07:45:26 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1540565126; cv=none; d=google.com; s=arc-20160816; b=inCN0gXP6HAlM0fkjYkqBIDaitUtCG2MwFhNAvLxABj3WSPs/kTJOU6kT0/S3iGWs3 7dTYmkt2JZov+SV/XabUeUjPY4FTV0iuSkcJavaynbHeGTGqfSdbKTwcJPhND38GPkTa vm1TRg5DoC906t9QVWOaDyFtKEeYOvxwdioPDyhpYlAXy0PVthgBi5l4xNVnv+6oPotv Gg615ZB8z8HMj6JDdv6pA0Rk5ENGYLTQqzfEW0loeJOVmHA64N5kzUSElekgVaZyTkeZ 1ry7VImNIpN9BcyBXdLq5R9zucejiWVc8jEUapsG2EzZrvJg8zuKUVDv0p+QC6xmKiY9 sKGQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=ZqT7S7ccSlN0Z4oiBOZYnQBnDGQDeTm2f/tIRaoUEO4=; b=V+P3LX7pNE1LM4pDcDhrl3ADW7yHzFbA5Nfy1Z9W3tzf24oT8OAqqB+EInIBATBW7B SiO2UB+PUdULY3dh4/3fdFM8xUUSKKIBBcyArUtZ6hWleJN7Go9TEcexYvo3lp12Drfb 14g2FS400Uhbqrx//YuvJBL6qtqyfNahT6LVDQw3qpI5gEoPItNSyOOX6+YSyAwwoxz0 jvLV4LC19XyX89T7f5W20va+xoBQVPSWSSoZMUc8MUA1YuLtO4ax2a90Iv0z4I1FdphG 9dGkYGIGkKprWqzFhI4rPn/bj2bY1TLriQNHNEbxpQgKmhlwHmXNJ3Vpou+njb4m+vDl HheA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@amarulasolutions.com header.s=google header.b=IwQkeVkX; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 136-v6si11253988pfw.278.2018.10.26.07.45.10; Fri, 26 Oct 2018 07:45:26 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@amarulasolutions.com header.s=google header.b=IwQkeVkX; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727826AbeJZXVp (ORCPT + 99 others); Fri, 26 Oct 2018 19:21:45 -0400 Received: from mail-pf1-f194.google.com ([209.85.210.194]:33744 "EHLO mail-pf1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727608AbeJZXVo (ORCPT ); Fri, 26 Oct 2018 19:21:44 -0400 Received: by mail-pf1-f194.google.com with SMTP id a15-v6so681591pfn.0 for ; Fri, 26 Oct 2018 07:44:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amarulasolutions.com; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=ZqT7S7ccSlN0Z4oiBOZYnQBnDGQDeTm2f/tIRaoUEO4=; b=IwQkeVkXMNjUbqG8HwSVKIlFeG2UDJLGlpb32wDzc5jnDs0TKyi8UfQ8Otm3LgsIyn YhgeEihQGExInby1uQLx0bNRQbdAc18wdR1WUphI5NzDUErZJL62BKY36F1lQ9OobsBJ c539CFIjvY1RMhiGduAsTT6tjYoNdJJB4F29I= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=ZqT7S7ccSlN0Z4oiBOZYnQBnDGQDeTm2f/tIRaoUEO4=; b=TOTtqJZsUoD8ZJeTiAhSI81p8Wbw6NFq8Mzytz7rMxNBlptuMKNFxQPrn1+L2is6DV YJF+5V1KyVKJaSyGBF0KOgNkjsp2NY5r2J0Uncui+rs1LXJ+EYr9N7ufuiSQEoAQIiUg 25gEcnbEzQRaRc5bfNDndSCvvYRdyZNIQ6NZeYAW7Bnno6hj1EOQcVm1I6FKvFACXlv1 mB0HAJO6RRy4VChgOa9pOOoXtOuZwl+IrUqkYZe1mG5Liyou76AmoWsJlutadRemPLeY pESLNbxmx+TYR2a2XI71eB+aWC1BxmSAYrJLtv49/X6sOEnuNZXWkf+/y7qQ3tCBLT4W jX2w== X-Gm-Message-State: AGRZ1gJc5CfsHNCt2FqQKmpdl4PvS1M9/3wUUuLnsZYhNDQNVxMCsINe UxCGYfa5VhUmA2fYsFJ+bluXdA== X-Received: by 2002:a63:b218:: with SMTP id x24mr3606180pge.223.1540565063890; Fri, 26 Oct 2018 07:44:23 -0700 (PDT) Received: from localhost.localdomain ([27.7.51.1]) by smtp.gmail.com with ESMTPSA id z22-v6sm12044467pgv.24.2018.10.26.07.44.18 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 26 Oct 2018 07:44:23 -0700 (PDT) From: Jagan Teki To: Maxime Ripard , Chen-Yu Tsai , Icenowy Zheng , Jernej Skrabec , Vasily Khoruzhick , Rob Herring , Mark Rutland , Catalin Marinas , Will Deacon , David Airlie , dri-devel@lists.freedesktop.org, Michael Turquette , Stephen Boyd , linux-clk@vger.kernel.org, Michael Trimarchi , linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-sunxi@googlegroups.com Cc: Jagan Teki Subject: [PATCH v3 02/25] clk: sunxi-ng: Add check for minimal rate to NKM PLLs Date: Fri, 26 Oct 2018 20:13:21 +0530 Message-Id: <20181026144344.27778-3-jagan@amarulasolutions.com> X-Mailer: git-send-email 2.18.0.321.gffc6fa0e3 In-Reply-To: <20181026144344.27778-1-jagan@amarulasolutions.com> References: <20181026144344.27778-1-jagan@amarulasolutions.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Some NKM PLLs doesn't work well when their output clock rate is set below certain rate. So, add support for minimal rate for relevant PLLs. Signed-off-by: Jagan Teki Acked-by: Stephen Boyd Tested-by: Jagan Teki --- Changes for v3: - collect Stephen Ack - add tested credit Changes for v2: - none drivers/clk/sunxi-ng/ccu_nkm.c | 7 +++++++ drivers/clk/sunxi-ng/ccu_nkm.h | 1 + 2 files changed, 8 insertions(+) diff --git a/drivers/clk/sunxi-ng/ccu_nkm.c b/drivers/clk/sunxi-ng/ccu_nkm.c index 841840e35e61..d17539dc88dd 100644 --- a/drivers/clk/sunxi-ng/ccu_nkm.c +++ b/drivers/clk/sunxi-ng/ccu_nkm.c @@ -125,6 +125,13 @@ static unsigned long ccu_nkm_round_rate(struct ccu_mux_internal *mux, if (nkm->common.features & CCU_FEATURE_FIXED_POSTDIV) rate *= nkm->fixed_post_div; + if (rate < nkm->min_rate) { + rate = nkm->min_rate; + if (nkm->common.features & CCU_FEATURE_FIXED_POSTDIV) + rate /= nkm->fixed_post_div; + return rate; + } + ccu_nkm_find_best(*parent_rate, rate, &_nkm); rate = *parent_rate * _nkm.n * _nkm.k / _nkm.m; diff --git a/drivers/clk/sunxi-ng/ccu_nkm.h b/drivers/clk/sunxi-ng/ccu_nkm.h index cc6efb70a102..ff5bd00f429f 100644 --- a/drivers/clk/sunxi-ng/ccu_nkm.h +++ b/drivers/clk/sunxi-ng/ccu_nkm.h @@ -35,6 +35,7 @@ struct ccu_nkm { struct ccu_mux_internal mux; unsigned int fixed_post_div; + unsigned int min_rate; struct ccu_common common; }; -- 2.18.0.321.gffc6fa0e3