Received: by 2002:ac0:98c7:0:0:0:0:0 with SMTP id g7-v6csp495101imd; Fri, 26 Oct 2018 11:50:12 -0700 (PDT) X-Google-Smtp-Source: AJdET5cFhKy9k45b3Zullnua30eT8kUmbwwe+VrUhauAUbcxiiqz8/NaUm9Cl/ie+yk5ATae5mVc X-Received: by 2002:a17:902:c01:: with SMTP id 1-v6mr4667448pls.233.1540579812331; Fri, 26 Oct 2018 11:50:12 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1540579812; cv=none; d=google.com; s=arc-20160816; b=wkzI1evJJbTjmeoHEhtP5NNFA4L9DsATX72YXUmCrGoeyeIxz51ofG3M4ohbMgYYgM 2zVjqv7K/TMucmxUitB8aMSi/zsNzqWVHMzJLF+6idqBBHoxlaxvHK/BibRytcGVQEsE IAbMNWyy7uLKSFORQxm60yF++GTO6UTnbs1taFLbRucwgem9RX1o1BJpfxlp0jvzbhw0 BByq6PWfZkJQc1q6HVwP9uE72NxAKiSHxKT59QO+68rMCaeTEGHudr+DfUrWd6+py6AR yWePKyoviVkQs9Iv5hF+2gcwteFYWOhTpz5g4HYuxbqk2KqdRVWhvIIs+7PHJByfLCbG GhaA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject:dkim-signature; bh=9eOI13aG3Owne4W1tN8Px2rCml38s/QfTsNL6mWlDxM=; b=nSEUfQKZuMMCkVCKZ43tttQ8Ki1Dup2/QX8VnNqci+v3wIOL1ZgL5ZoDL4gIFY4Xhl O+gIJ2gT7JWOLxJB1L3ifyoXD/AfF4QeYE+KF5KMl480l6vSPvGauBbjTe+uVdHtXuKC h7ZSZJaOAcheYpgJVOcOv/TbaID42czym7e5W55jgNpQXgi/3hkVT2RGBSqbMMysx/kS dGJLgUgJTv8pJsL7knbbPVuqHO13FpQChmVUUXu6SX0/1zrDIU8KB4OxD/NVqKCAgr/M ukmZQY468n+R6JtfGid51N6I3faApvIXVirMhD2qd2RTqsZdmC1E7HM7I9bSxCWc8KmK ATqQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@lightnvm-io.20150623.gappssmtp.com header.s=20150623 header.b=EIKQLJCp; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id y1-v6si12379925pgf.78.2018.10.26.11.49.55; Fri, 26 Oct 2018 11:50:12 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@lightnvm-io.20150623.gappssmtp.com header.s=20150623 header.b=EIKQLJCp; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728049AbeJ0D1n (ORCPT + 99 others); Fri, 26 Oct 2018 23:27:43 -0400 Received: from mail-lj1-f193.google.com ([209.85.208.193]:45856 "EHLO mail-lj1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727986AbeJ0D1m (ORCPT ); Fri, 26 Oct 2018 23:27:42 -0400 Received: by mail-lj1-f193.google.com with SMTP id j4-v6so2059878ljc.12 for ; Fri, 26 Oct 2018 11:49:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=lightnvm-io.20150623.gappssmtp.com; s=20150623; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=9eOI13aG3Owne4W1tN8Px2rCml38s/QfTsNL6mWlDxM=; b=EIKQLJCpFryl7wwTlpAAYIWI/AMdvXiy5oKEt+tYOUsQeII55gOtqZcOXTGsJoJoOa E9qlfHMKntqeKbUB+qpR4PzuXIpvgOKDHONm/sQsqGhhMWJhMSBTxl8BOJYJkU6yAOng 8I3MjJadrt3ZclqDJs6tT91WaWdUyWY9l4Icu3W7AVtekN1NI2er83UZI8gjGAAWBdGs QJvHszKfHOPR5ifn38PR7EYkwJv+vU5X8WzKaNQsmp95c/n/8WRnUAnJxbAUaoLUbq0g Ej5jof5xgAbt6eGbJG0Jettrn/O+muo2PbEuASkp57JZMBGk5nxeoxB9R+FH53OTyTP5 aNlA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=9eOI13aG3Owne4W1tN8Px2rCml38s/QfTsNL6mWlDxM=; b=Ly1i7XzjHSUKlBdmBNjc0hZ//TU8B9MketeKHe81cuKUROrpOw+LlL5KgSS5llcpzH BymFHHs5mhe1FmHCAh5hrJBUnqe0tfOJ/LUBErcC/qCgHJl6x3eqpZwFK2a6KFJViRcY aIe4C+o0xZ+hbb+uC8+Dm+BBkL54yEwyiuQzSasSdH8kpgCRO4Gvd1oAW8MJirrXBOsY uLOxPWfSLGWMvum0kn3gKDSy6TzEu5TFKbuHQWVdsmz/9dKy7LyCH1R6MLIp3RjpmOCh t/LOeR11kNj9yTLyzRDW+DcVfhjvjdBnPfVD5qkNpzN1nBblvv3sfVkmm7+vgU6aEi5j FdyA== X-Gm-Message-State: AGRZ1gLhr4z+IOSErJlLMi5zMJ+A28gOm+06yUKJzKeVAoq785aFvEdP D7lu1vgINXly45g4gcIDrP9N9Q== X-Received: by 2002:a2e:4e01:: with SMTP id c1-v6mr3388818ljb.157.1540579771668; Fri, 26 Oct 2018 11:49:31 -0700 (PDT) Received: from [192.168.0.36] (95-166-82-66-cable.dk.customer.tdc.net. [95.166.82.66]) by smtp.googlemail.com with ESMTPSA id k72-v6sm548894lfg.5.2018.10.26.11.49.30 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 26 Oct 2018 11:49:30 -0700 (PDT) Subject: Re: [PATCH] lightnvm: pblk: fix chunk close trace event check To: hans@owltronix.com Cc: linux-block@vger.kernel.org, javier@cnexlabs.com, linux-kernel@vger.kernel.org, hans.holmberg@cnexlabs.com References: <1540541544-7761-1-git-send-email-hans.holmberg@cnexlabs.com> From: =?UTF-8?Q?Matias_Bj=c3=b8rling?= Message-ID: Date: Fri, 26 Oct 2018 20:49:29 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <1540541544-7761-1-git-send-email-hans.holmberg@cnexlabs.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-GB Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10/26/2018 10:12 AM, Hans Holmberg wrote: > The check for chunk closes suffers from an off-by-one issue, leading > to chunk close events not being traced. Fix this. > > Fixes: 4c44abf43d00 ("lightnvm: pblk: add trace events for chunk states") > > Signed-off-by: Hans Holmberg > --- > > drivers/lightnvm/pblk-core.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/lightnvm/pblk-core.c b/drivers/lightnvm/pblk-core.c > index 6944aac43b01..6581c35f51ee 100644 > --- a/drivers/lightnvm/pblk-core.c > +++ b/drivers/lightnvm/pblk-core.c > @@ -531,7 +531,7 @@ void pblk_check_chunk_state_update(struct pblk *pblk, struct nvm_rq *rqd) > if (caddr == 0) > trace_pblk_chunk_state(pblk_disk_name(pblk), > ppa, NVM_CHK_ST_OPEN); > - else if (caddr == chunk->cnlb) > + else if (caddr == (chunk->cnlb - 1)) > trace_pblk_chunk_state(pblk_disk_name(pblk), > ppa, NVM_CHK_ST_CLOSED); > } > Thanks Hans, Applied for 4.21/5.1. Note that you're sending from your owntronix email account. Checkpatch complains that sender and author doesn't match.