Received: by 2002:ac0:98c7:0:0:0:0:0 with SMTP id g7-v6csp1761592imd; Sat, 27 Oct 2018 17:11:30 -0700 (PDT) X-Google-Smtp-Source: AJdET5f05QQythZBE1u62pm4DKyjV9l2M8OmPTvF1wdcAOGvi1VpCfCdP3kiihReh2Dx7BVD5Q/T X-Received: by 2002:a63:515b:: with SMTP id r27-v6mr8669044pgl.419.1540685490048; Sat, 27 Oct 2018 17:11:30 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1540685490; cv=none; d=google.com; s=arc-20160816; b=oaT6+Sc3vMyhxHM3cqhh9py/yc/idLdFNztBOm4D9btcpcOwIr3mJfxjC3rlheoksj /PmKTt935BaYhBjw6RjDFhE5HQdVgaeGaLQ/4g2YPeROIUGvwIPXMOY0wYkG9XjYiS9P a6+nYXHQAvpNn/QFx0Cla/qT1RsYMehk6/F7Pzo48jswxNh8X8lHf+AG9sTTl4JOrc4G CPiGOZEwpBc8/qSxLLtUaKuKbRBI9jeRlSe0EDyNZrSy9DJW0UeuEOHnqb268WahxY4n DGMbsWsOlvR5Yn/hOjzRhojOJPBCIxku6igR9uuzmfT9ihUF+RqSV/XIgyYCeZWRdjm7 3q1w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:from:subject:cc:to:message-id:date; bh=UtSR9L5jqRq0Q+s0le1dj+aBIlABK/X68IJY4NAaDvU=; b=n5dQUycobzep8rpIjZBItjRVi1SQdh8z5qHQlQauHIhJC3y0EgQREyZNGQoVHTwh8I jTisTP1PCm43HnHW3Ldd3vi5W2gzyjAZoswrRdgN3w+Ah9WaVRCUvPT2HKyGMtKwvmgJ Iu88ewblA2BTwqxpujVqgQfLI060wZlZ67cmXY8aa/o0xw9KlAvV+EoS9xz6p8ejgn9P wtYuWlm/Co85YeClfz9SwrRB49IOnYEumGdSq5ivo9i8xizeWff2+iJLInYZYtUGhcnj GwjpYmmVDfIPM7wXomHrrxF0q2pOHaQwRP9Rk7evQu8vg0tff7nK8EyHc2TzWSDTpAEW GXLg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id c18-v6si6742529plz.116.2018.10.27.17.11.12; Sat, 27 Oct 2018 17:11:30 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728874AbeJ1IqV (ORCPT + 99 others); Sun, 28 Oct 2018 04:46:21 -0400 Received: from shards.monkeyblade.net ([23.128.96.9]:37558 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728630AbeJ1IqV (ORCPT ); Sun, 28 Oct 2018 04:46:21 -0400 Received: from localhost (c-67-183-62-245.hsd1.wa.comcast.net [67.183.62.245]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id D2A0B1487DEB8; Sat, 27 Oct 2018 17:03:35 -0700 (PDT) Date: Sat, 27 Oct 2018 17:03:33 -0700 (PDT) Message-Id: <20181027.170333.305158882844306852.davem@davemloft.net> To: tomasbortoli@gmail.com Cc: vyasevich@gmail.com, nhorman@tuxdriver.com, marcelo.leitner@gmail.com, linux-sctp@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] sctp: socket.c validate sprstat_policy From: David Miller In-Reply-To: References: <20181027202026.32157-1-tomasbortoli@gmail.com> X-Mailer: Mew version 6.7 on Emacs 26 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Sat, 27 Oct 2018 17:03:36 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Tomas Bortoli Date: Sat, 27 Oct 2018 22:43:43 +0200 > I just realized we also have to check for less than 0 indexes.. How about the fact that your original submission didn't even compile? I hope you realized that first.