Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH v3] libata: Apply NOLPM quirk for SAMSUNG
 MZ7TD256HAFV-000L9
To:     Diego Viola <diego.viola@gmail.com>, axboe@kernel.dk
Cc:     tj@kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org
References: <20181026134516.1234-1-diego.viola@gmail.com>
 <3d9dd60b-7bfe-bc1c-b971-0935a84dcf45@kernel.dk>
 <CA+ToGPHR7s4kTKdSh3rpjvxPQN+Y+Qfv=vT2icJ1Gh55X3-mTg@mail.gmail.com>
 <CA+ToGPFMgT2co9c+QWN=7etS9w0OaRfUz69hduOn5rRvMwdsbg@mail.gmail.com>
From:   Hans de Goede <hdegoede@redhat.com>
Message-ID: <539a21b1-7d09-4f30-0421-d083d1c48ee4@redhat.com>
Date:   Sun, 28 Oct 2018 11:48:42 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.8.0
MIME-Version: 1.0
In-Reply-To: <CA+ToGPFMgT2co9c+QWN=7etS9w0OaRfUz69hduOn5rRvMwdsbg@mail.gmail.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Hi,

On 28-10-18 05:13, Diego Viola wrote:
> On Fri, Oct 26, 2018 at 5:36 PM Diego Viola <diego.viola@gmail.com> wrote:
>>
>> On Fri, Oct 26, 2018 at 11:21 AM Jens Axboe <axboe@kernel.dk> wrote:
>>>
>>> On 10/26/18 7:45 AM, Diego Viola wrote:
>>>> med_power_with_dipm causes my T450 to freeze with a SAMSUNG
>>>> MZ7TD256HAFV-000L9 SSD (firmware DXT02L5Q).
>>>>
>>>> Switching the LPM to max_performance fixes this issue.
>>>
>>> Applied, thanks.
>>>
>>> --
>>> Jens Axboe
>>>
>>
>> Jens, Hans,
>>
>> Thank you.
>>
>> Diego
> 
> Hi Hans and Jens,
> 
> I just wanted to give you guys an update about this problem.
> 
> I've managed to update my SSD firmware to the latest version[1].
> 
> For running the update, I've had to install Windows 10, ran the
> firmware update, remove Windows and reinstall Arch Linux.
> 
> The latest version of the firmware is DXT04L5Q, and it looks like
> there hasn't been a new update since 2015.
> 
> I'll be running with med_power_with_dipm and hope this firmware update
> fixes the problem, if it doesn't and I get another freeze, I'll send
> another patch blacklisting the drive completely. Is that OK?

Yes, if it still happens with the latest firmware then blacklisting
it completely is the right thing to do.

Unfortunately for reasons which I do not understand OEM SSDs often use
different (customized?) firmware compared to the model on which they
are based and often see less updates and seem to have more bugs :|

Regards,

Hans