Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
DMARC-Filter: OpenDMARC Filter v1.3.2 vulcan.natalenko.name E5FEB44BCA4
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII;
 format=flowed
Content-Transfer-Encoding: 7bit
Date:   Sun, 28 Oct 2018 13:22:09 +0100
From:   Oleksandr Natalenko <oleksandr@natalenko.name>
To:     David Miller <davem@davemloft.net>
Cc:     dave.taht@gmail.com, hkallweit1@gmail.com, toke@toke.dk,
        jhs@mojatatu.com, xiyou.wangcong@gmail.com, jiri@resnulli.us,
        netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: CAKE and r8169 cause panic on upload in v4.19
In-Reply-To: <20181027.214426.537959459795607171.davem@davemloft.net>
References: <fbd7f0b8-10c8-be17-fce6-327a95d8ea2e@gmail.com>
 <CAA93jw7xoaokrN4oGAyqh6JHAn8nJpUpp_wj-iy+GWNoV-ipNA@mail.gmail.com>
 <b80e6819da8ea74f18b6ec0aaf9128fa@natalenko.name>
 <20181027.214426.537959459795607171.davem@davemloft.net>
Message-ID: <3d749bf1ec48ee9f4172b23bde84ec4b@natalenko.name>
User-Agent: Roundcube Webmail/1.3.7
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Hi.

On 28.10.2018 05:44, David Miller wrote:
> Does this fix it?
> 
> diff --git a/net/core/dev.c b/net/core/dev.c
> index 022ad73d6253..77d43ae2a7bb 100644
> --- a/net/core/dev.c
> +++ b/net/core/dev.c
> @@ -5457,7 +5457,7 @@ static void gro_flush_oldest(struct list_head 
> *head)
>  	/* Do not adjust napi->gro_hash[].count, caller is adding a new
>  	 * SKB to the chain.
>  	 */
> -	list_del(&oldest->list);
> +	skb_list_del_init(oldest);
>  	napi_gro_complete(oldest);
>  }

Yes, but I had to apply both a8305bff6852 and 992cba7e276d too to get it 
compiled. With these 3 patches the panic is not triggered any more while 
having GRO enabled.

Thanks!

-- 
   Oleksandr Natalenko (post-factum)