Received: by 2002:ac0:98c7:0:0:0:0:0 with SMTP id g7-v6csp2435940imd; Sun, 28 Oct 2018 10:00:12 -0700 (PDT) X-Google-Smtp-Source: AJdET5eXZN6+90uUCQGn1EfI1K3ZBkT7NrGZ9GzrGpHkHaYxphlm0A9DpALm3If2t3yvDGD6vQjo X-Received: by 2002:a62:388b:: with SMTP id f133-v6mr11852517pfa.48.1540746012499; Sun, 28 Oct 2018 10:00:12 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1540746012; cv=none; d=google.com; s=arc-20160816; b=O+HP4TVP87BaTSCNIF0bjlkXDUsIxkWt+MHpt33565d1SFO4QCk1LUAF4GWeazpNSd CYLJvyP+3Wofee0EwzKm1g/oYbpf17kNR8KRdSSHgNB2GZGXyovXoCKYEQV6wRUf+c7f B/hscPglQyRxYh/cfpX5sGqt5a/KLr8/kpAQZM5nQzGz8EBTpbKl9/DW94KzTdpByIdS CcSrDIo92LeHL9rgPbVijRIkhtVxdsSeK7vOnzyCfdIyypdKzXoSW6chIbTsCN/zHSg7 ymz1WioSiGgQ7XINO1znCUcH4Dn/qAJKJaa+ATBK0wVUd9fN1+a9E1rVwdx1aGSrqq5B 2ZWw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date :dkim-signature; bh=4U7i2h6nKK2IPIkOGm5QbO2JPW0h//r/PXbSFEji9pk=; b=d2RsayNQackvfx8KaXmn+GB2O2xGhMROHaqiJPTJs6SKI35LXlft+F4scvXRO2wVjh uSoTc5rsyhFKDH8ZzKSXSlzDxEn2pcveTWNfjnPHXQSZ1ylijL93hL2kjvVPEqfg4/76 E/whm8RSOXt1YK3Bp5x3ZJ3Horm1EYzkQppcd5bDZOLBpeFtFFQnkQS8rIo/d3UnQUr7 uLASL+EvddExywN1YLBu1CPH7fe+iBjkQED11u/HAiYPo2ZS9NgOHwNTqjjXjkeSFOaj jGqddmBDA/5kII3yC0Xm08hAirHw52QIGDJuX2mSP+H2jMzHVGXzLo7I4CifwH0m5TzD 4vgQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=k1JrX+Hb; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id b65-v6si17917906pfa.92.2018.10.28.09.59.53; Sun, 28 Oct 2018 10:00:12 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=k1JrX+Hb; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727962AbeJ2BhQ (ORCPT + 99 others); Sun, 28 Oct 2018 21:37:16 -0400 Received: from mail.kernel.org ([198.145.29.99]:34038 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726492AbeJ2BhQ (ORCPT ); Sun, 28 Oct 2018 21:37:16 -0400 Received: from archlinux (cpc91196-cmbg18-2-0-cust659.5-4.cable.virginm.net [81.96.234.148]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id DAFD52064C; Sun, 28 Oct 2018 16:52:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1540745526; bh=Q25RdGMcKDdcPcVKKRfxnuf3ykl948biB8E8fK9bK5w=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=k1JrX+Hb+oTfYV7uF/QcJbojp87E5NL+F/Z/6uliVly/N7lVznPm9c7UzWN9W0z0H Ml+j+iv+dnOO4AOrqcgqvecu5MAQGq/A93wA1UGKVqPyY+uM7jfTMYyDFQ5XI5Pdls dxyX0spiqRzuJNbqfodWL93kT4Zbs9B1VeJMCzRk= Date: Sun, 28 Oct 2018 16:52:02 +0000 From: Jonathan Cameron To: Matheus Tavares Cc: Lars-Peter Clausen , Michael Hennerich , Hartmut Knaack , Peter Meerwald-Stadler , Greg Kroah-Hartman , linux-iio@vger.kernel.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, kernel-usp@googlegroups.com Subject: Re: [PATCH v2 0/6] staging:iio:ad2s90: Add scale info and improve error handling Message-ID: <20181028165202.52ee89b3@archlinux> In-Reply-To: <20181027020005.3140-1-matheus.bernardino@usp.br> References: <20181027020005.3140-1-matheus.bernardino@usp.br> X-Mailer: Claws Mail 3.17.1 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 26 Oct 2018 22:59:59 -0300 Matheus Tavares wrote: > This patch set adds scale info to ad2s90's single channel, improve > error handling in it's functions and fix a possible race condition > issue. > > The goal with this patch set is to address the points discussed in the > mailing list in an effort to move ad2s90.c out of staging. Thanks, A good series in general. A few suggested improvements. If I haven't commented on a patch, usually it means I'm happy with it and will pick it up with the rest of the series. Jonathan > > Changes in v2: > - Added my S-o-B in patch 5. > > Matheus Tavares (5): > staging:iio:ad2s90: Make read_raw return spi_read's error code > staging:iio:ad2s90: Make probe handle spi_setup failure > staging:iio:ad2s90: Remove always overwritten assignment > staging:iio:ad2s90: Move device registration to the end of probe > staging:iio:ad2s90: Check channel type at read_raw > > Victor Colombo (1): > staging:iio:ad2s90: Add IIO_CHAN_INFO_SCALE to channel spec and > read_raw > > drivers/staging/iio/resolver/ad2s90.c | 55 ++++++++++++++++++--------- > 1 file changed, 37 insertions(+), 18 deletions(-) >