Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Sun, 28 Oct 2018 13:18:33 -0400 (EDT)
From:   Alan Stern <stern@rowland.harvard.edu>
To:     "Cherian, George" <George.Cherian@cavium.com>
cc:     "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
        "gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
        "mathias.nyman@intel.com" <mathias.nyman@intel.com>
Subject: Re: [PATCH] xhci: Add quirk to workaround the errata seen on Cavium
 Thunder-X2 Soc
In-Reply-To: <1540661892-189850-1-git-send-email-george.cherian@cavium.com>
Message-ID: <Pine.LNX.4.44L0.1810281305140.23762-100000@netrider.rowland.org>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Sat, 27 Oct 2018, Cherian, George wrote:

> Implement workaround for ThunderX2 Errata-129 (documented in
> CN99XX Known Issues" available at Cavium support site).
> As per ThunderX2errata-129, USB-2.0 device may come up as USB-1.0
> If a connection to a USB-1.0 device is followed by another connection
> to a USB-2.0 device, the link will come up as USB-1.0 for the USB-2.0
> device.
> 
> Resolution: Reset the PHY after the USB1.0 device is disconnected.
> The PHY reset sequence is done using private registers in XHCI register
> space. After the PHY is reset we check for the PLL lock status and retry
> the operation if it fails. From our tests, retrying 4 times is sufficient.
> 
> Add a new quirk flag XHCI_RESET_PLL_ON_DISCONNECT to invoke the workaround
> in handle_xhci_port_status().

Minor nitpick (for both the patch description and the code comments):

USB 1.0 was never widely adopted and is not used any more.  The
earliest vesion of USB currently used in supported devices is USB 1.1.  
Likewise, there are a few devices around that support USB 2.1, not
USB 2.0, but they are presumably also subject to the problem described
above.

I suggest you change the description and the comments to refer to USB 1 
and USB 2 instead of USB 1.0 and USB 2.0, as the latter are too 
restrictive and misleading.

Alan Stern