Received: by 2002:ac0:98c7:0:0:0:0:0 with SMTP id g7-v6csp2600326imd; Sun, 28 Oct 2018 13:46:57 -0700 (PDT) X-Google-Smtp-Source: AJdET5e5LFNmoabWp/5WO1ByYbOExxiBQ5+anBBa2DMAUwhRPBzeUBiAisWxQQo93rFBHf8i8DAH X-Received: by 2002:a62:2b41:: with SMTP id r62-v6mr5517225pfr.105.1540759617149; Sun, 28 Oct 2018 13:46:57 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1540759617; cv=none; d=google.com; s=arc-20160816; b=g08VKEv1211oldCvK5y+aDQ+dVFLdIitiUR+Xn7y74Y2e3xA2OFmu1Qh3vO8nnVaoF ZJDq2fEWUZ0ascKJ8jgUzjpTk59sqZG/5CKCK0uimxKvcP3efNFcoY7Xsv21TIYmWzt9 Sk+o3XYwcQPoWrwZ/q3HR5pnWm0uqtRxQ9jnFGcmXOYdhq7jAyQ8cGMinqFgnQFPXmFz 1Tith2vrXAiKqhOOQ0+X49BJGYJvqv4l7Tpfaqp0i2jLJjiGFuH9vUItYOzxOOtfmVDT 2SaYPhu/rNSpltQeYsTuhi9GgM409HbZBjPV48RuTIzOHAvlWNQBjz1S/VJf4c0YI3wi 9OAQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:importance:content-transfer-encoding :mime-version:subject:references:in-reply-to:message-id:cc:to:from :date; bh=o2/owDbC9LO+qvJr2hCZcjZGL4zf8lPjm+cipYcUruA=; b=QdeHWMRhJwZfZZ4qZTF8QFvwxjL4BkKfOwqUMQ+uY5zfxq57oJnu9ZZxDXdDxHf38h fGRnHkJgB9aXuwkq3WVIwlrCG+Rvw16HJ1+Mjtd5s1UyinVGsGkEpwU8Abhmr66351dW GEAJDoCAM8JLh3g4eLm18H2o9zbA5vneUl5g4X5/vYk9cFeG8PHPckeLrPnQGJbqRD3U lvDUy86I1IRdvB5odSwPv9FbC2Rli1B9ElcMv7zwql+dCGb8hOwyIQwHU4UvBoytP8w9 Zm+2OArR2yGtaPgopbs7puLGU2ZvlBndZDxB49Nhdn9rRSQhbhR1G5J55meMb8T1f9Bx Zmtw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id p2-v6si18012112plk.264.2018.10.28.13.46.41; Sun, 28 Oct 2018 13:46:57 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727651AbeJ2Fbz (ORCPT + 99 others); Mon, 29 Oct 2018 01:31:55 -0400 Received: from mout.kundenserver.de ([212.227.126.131]:38301 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725841AbeJ2Fby (ORCPT ); Mon, 29 Oct 2018 01:31:54 -0400 Received: from null ([212.227.220.15]) by mrelayeu.kundenserver.de (mreue001 [213.165.67.97]) with ESMTPSA (Nemesis) id 0Lq1ku-1fdOJp2QgC-00dmaY; Sun, 28 Oct 2018 21:45:41 +0100 Received: from null ([212.227.220.15]) by mrelayeu.kundenserver.de (mreue001 [213.165.67.97]) with ESMTPSA (Nemesis) id 0Lq1ku-1fdOJp2QgC-00dmaY; Sun, 28 Oct 2018 21:45:41 +0100 Date: Sun, 28 Oct 2018 21:45:39 +0100 (CET) From: Stefan Wahren To: Nicolas Saenz Julienne Cc: linux-rpi-kernel@lists.infradead.org, eric@anholt.net, gregkh@linuxfoundation.org, linux-arm-kernel@lists.infradead.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, dave.stevenson@raspberrypi.org Message-ID: <1781917429.4071.1540759539282@email.ionos.de> In-Reply-To: <20181026134813.7775-10-nsaenzjulienne@suse.de> References: <20181026134813.7775-1-nsaenzjulienne@suse.de> <20181026134813.7775-10-nsaenzjulienne@suse.de> Subject: Re: [PATCH RFC 09/18] staging: vchiq_core: do not initialize semaphores twice MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Priority: 3 Importance: Medium X-Mailer: Open-Xchange Mailer v7.8.4-Rev39 X-Originating-Client: open-xchange-appsuite X-Provags-ID: V03:K1:AP132CI8f7r0+10ZQlbynbHoAyjHk37j7zXWu2dYfoRr7twQrmv /jbP3ztBzSnK3fZoX1O2IwNgGZIWUGi5+iZI5vPA0oHhC+rcFjYlwQQkJGv8g2SySuPhWqy 9j86KiZoYIzeWS6bVUEgR5WIXfQfiwUGCw9qXno2GjIuX9fv50ciuaCCDcIgvnRTAtW4mSd ozAcaztliVAokNjFBtRXg== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V01:K0:QIX2j605bA4=:rAhGAoFHoAwXxDQbeFB22z Fl/8l/TslZF1dA/LC9hD6eFYgL0N5Bcg+wd5YZorsm6wVDIBU38KPYrRlteN2hezUzsGn7Bwq BS/BaQxo3iMlciVz5By2oCu+FC59/3ZN5eTW4rOnDJSeelj91/E1eHVTLtHMNPbkReRSulZrX INChZSmzvQthvX4yHzNdh5oNbGam5mbZe/It9EjwfMgx6F02H8PhiY2C4EvppfmfuZ/v2oYU7 0U0YiYuCm63qbTRTlLT+DlXNNl1Pyd5mzg/um4SmcbSjSgORkpaeVMHDsOgNo6zF4wKn/mAq/ ZXLjFFsGl0rqWlbe3XBs+ebnj+YQGIit3Sp5yNXFYfZddVfE4giMLpZ/tE2G5qvsFPHbiPWYc yN+b3DwWoGJzk3L/bmdd5zHcsUN/VXck3uB0uAe7b+rPoKa3XZKq1BTzC1cdLFI8YBxcY866k k8OSrRcoBPnwAGndj/C73Xkpgsk61wx0u7tUu+C0Z4ZVx0XBgQu+yPf/BK+hhN9PuITVkDlqy JPK/iP8YG07yom3k0okQMf4jpUs90R+FFCEOzQO9BveRUNWPF2IlUibOUGt29/bJQePXCBQMW 5lZJyAzEhxlF5d6kyRzUFRS3EwZQDjhNeflEAKXbVzJHSfgVOYr0/JNLEdo3ocEK+lS9+lzGq thRvXpdneF4PW79RgLiz9aN7Q8j/cK3EnTTOoh4nIUWDvbBHhVLg8bPZ/+Iuzbx2wMGq9Yy0Z O2KQFih27prlFGgN Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Nicolas, > Nicolas Saenz Julienne hat am 26. Oktober 2018 um 15:48 geschrieben: > > > vchiq_init_state() initialises a series of semaphores to then call > remote_event_create() on the same semaphores, which initializes them > again. i would prefer to have all init stuff at one place in vchiq_init_state() and drop this ugliness from remote_event_create() instead. Is this possible?