Received: by 2002:ac0:98c7:0:0:0:0:0 with SMTP id g7-v6csp3035697imd; Mon, 29 Oct 2018 00:11:36 -0700 (PDT) X-Google-Smtp-Source: AJdET5eqmb+WM5eKhW+jpZNdV8UwgCGN0gD04Vve6RGif0Dc2X2q1ldI/IYIRX+vv4NujQ6Ob7F8 X-Received: by 2002:a62:fb04:: with SMTP id x4-v6mr13939116pfm.210.1540797096805; Mon, 29 Oct 2018 00:11:36 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1540797096; cv=none; d=google.com; s=arc-20160816; b=TkXNjZvnD57BcP3ps+eS0Ojp6zCyzV8aCd3cYNszm72b49NrZ4Vfp8yaCg/TEFFNdb lq3KmixOwVqm/ghgeuO+3sfeMh8Lu+DreqitXPBhuHS6rUiHPrI8BjFiC6l/kMYmogbn 1/KOE9EOskFu0noxBTDVI4QGkdjx9MppAbs0iyzSzXn2u9aJJXzKDPFr5f501r8Af2qn OaOsWfBO7YURbDl6Y3lRN+9AJOR4Ys7hs0UjJ9f9z8qJrRPhAzh+8weCHDLYt5DnesGL XytY4PFlHJnB7/v+WtEe1dSm0IcEJraIH4yvn+cE6rMLsGJgHlPDGIBman/37ex8qr0z aQog== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=UzBb+T0NR0lbTNlbJiUGUnHjDnspOZ46tkVSsWW8dWE=; b=SSjrVwZrIRm5YAy67fxRIyOfeX6HTYcrDy7k7Mh22+oo5GFmRJXVb5RQGhnijLu0mY b8ij3Y9j/1SkRkmPQG+cE+f5+sO/zIr9XMGy6V+4ksZrCv699EpbykAtpKdaiWaZtoPx rpB/sxSLlLbo/dSs8Pb/EhtbiC9cxM0ysTcNYoG8XEagpCsib2jnufPddmfoMU0APflt sk9pNUVCRYvmHNnV5x66yggYfz+412OsUFgIG2aPE00pGcKfNiTeJ7mq4osMn2uRTW87 TEu3sh2FNF9yR9Nzbv7HGjGjNHK8UI8/6pgymJ284qRGcZ7KbDssfBN6FEWhtf0y+f2T 65Pw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id z14-v6si4320816pfc.11.2018.10.29.00.11.21; Mon, 29 Oct 2018 00:11:36 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729390AbeJ2P6F (ORCPT + 99 others); Mon, 29 Oct 2018 11:58:05 -0400 Received: from ipmail07.adl2.internode.on.net ([150.101.137.131]:19212 "EHLO ipmail07.adl2.internode.on.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729225AbeJ2P6E (ORCPT ); Mon, 29 Oct 2018 11:58:04 -0400 Received: from ppp59-167-129-252.static.internode.on.net (HELO dastard) ([59.167.129.252]) by ipmail07.adl2.internode.on.net with ESMTP; 29 Oct 2018 17:40:40 +1030 Received: from dave by dastard with local (Exim 4.80) (envelope-from ) id 1gH1h8-0003rb-NA; Mon, 29 Oct 2018 18:10:38 +1100 Date: Mon, 29 Oct 2018 18:10:38 +1100 From: Dave Chinner To: Anatoly Trosinenko Cc: "Darrick J. Wong" , linux-xfs@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: XFS: Hang and dmesg flood on mounting invalid FS image Message-ID: <20181029071038.GL19305@dastard> References: <20181029012058.GK19305@dastard> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Oct 29, 2018 at 09:57:20AM +0300, Anatoly Trosinenko wrote: > > How did the corruption occur? > > It is a fuzzed image. Most probably, it was artificially "patched" by > fuzzer. Or do you mean "what particular bytes were changed"? I wondered how this specific corruption occurred in the real world. If i was a real world problem, it would have been indicative of a code bug if it did occur (i.e. whatever wrote the log record would have been broken) but seeing as it's a fuzzer problem, I don't need to look for any code bugs other than "we didn't validate the input properly". Cheers, Dave. -- Dave Chinner david@fromorbit.com