Received: by 2002:ac0:98c7:0:0:0:0:0 with SMTP id g7-v6csp3081889imd; Mon, 29 Oct 2018 01:07:20 -0700 (PDT) X-Google-Smtp-Source: AJdET5fiWl5w/wMYLTgqhz/IY2H2i2+FjXt6atjb8oU2VG4bb9YMic569rM8PVGjJXVPDILcDEqQ X-Received: by 2002:a63:8c4:: with SMTP id 187-v6mr12952187pgi.396.1540800440661; Mon, 29 Oct 2018 01:07:20 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1540800440; cv=none; d=google.com; s=arc-20160816; b=mxdOANkkqme0GAqwtb45ly7WiVqOzI3kbERsuwc8ymLipcL4BBLNEO58cn9xCmV/RV yyTKM5GMRYF3V8VBL0QSccm55/Sr2edfCRvu9Kxm59ynUe8hFDpBUuMG9vzj0Ol5NKKO o+MIsnSvcAa1wsJ9CbuMygl/YhDpi9zSQZeldTz/37/vluUAn/z1xlSO1CVthHKTRkAF UeNM2HTUF35Djs5+BM7iua8wuuuvMCYdydjvnPX1FE7ouFDB02yQYkCo9F94FB6LWbVR 9685fhf+Ny/4HD4JI9S4Wg6hSvsMGStW36HNP2zxb2UEB2qZWfOwR16e/9JpQwEpYetK hhrg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject:dkim-signature; bh=ajaYwJF4Ljrrll4IuoXvlD3RjAFhr9gdHOnHhXAu5Zs=; b=u/oXKn6VgLSpx6nb10anUCyRcjjTNQBsdNfvBbHNB4J+hd6BQSaityZSw6bpf75ARg F6PAb94SPRo06YtqXc0raxLPH87SIFksfiVmGcYnMCwQio1KsJr0u/1RFpGKzfnvAS6x cp0KU3MqDuzKmoOMO6W8GXEMkKgJNM0dELC43CBgJwFkbGuhZAj3ZSpHTSjXq2YR6GsZ yuSpZ59R0BFQt4hZqOohEIiQNViXhG7oKA52t9Ec29be3Am38hpqIl7tPCosAIXhIqzk KLubKDaoW+xpOG6A9tim4/W/QQi1ByzoXgJcMthvQWoXWXRxhI2tKV6uMJ+qU1jFEkr0 Tg5A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@cogentembedded-com.20150623.gappssmtp.com header.s=20150623 header.b=bgtfFerz; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id s8-v6si13069080pgf.15.2018.10.29.01.07.04; Mon, 29 Oct 2018 01:07:20 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@cogentembedded-com.20150623.gappssmtp.com header.s=20150623 header.b=bgtfFerz; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729374AbeJ2QyN (ORCPT + 99 others); Mon, 29 Oct 2018 12:54:13 -0400 Received: from mail-lj1-f194.google.com ([209.85.208.194]:46254 "EHLO mail-lj1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726036AbeJ2QyM (ORCPT ); Mon, 29 Oct 2018 12:54:12 -0400 Received: by mail-lj1-f194.google.com with SMTP id x3-v6so6821077lji.13 for ; Mon, 29 Oct 2018 01:06:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cogentembedded-com.20150623.gappssmtp.com; s=20150623; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=ajaYwJF4Ljrrll4IuoXvlD3RjAFhr9gdHOnHhXAu5Zs=; b=bgtfFerzqxC6ZUuW/O5tRqis/zoiuS3TRapqRabfRAjRT6CbGF3xgSXW/A9SlH2G4O s/JXPY7DoPAYN0uosA05sDINjNfda8s2Nq6OapQWkAyjEuyKBqs10HB7CSvEe14F5iEW ZroMXJabEv34xiq5PH9zA7msP+7mqsRx2TqRJCOjq5I6oYTP/WDWWSzIYrjCkIl2ptTz UX4P25hpz71nbGq1MgfQfwCnRO64i/GrEXANeX6hTTT/fGunYPdkCMCIb217u0ypIPrm SPg9tGHE5M7ql0UsRWXrROLk3cCNHkiWOvY98Iuzbl6d1fjcwl3/ULZmjj0krWyOOi5K iQpg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=ajaYwJF4Ljrrll4IuoXvlD3RjAFhr9gdHOnHhXAu5Zs=; b=B9jb7BE5dSt+F9eGKLFHKRbQ5c8MoiLzNhGThXtSHCsOruFEeKB06a37FlIgt10qA+ 65M7MtG9AHopwGN7Quo39od39K6uE8w3wbQRtK1jcsaZL7TX2q1SIq2EYgVUCAO03FJU 0j+c/isqoYhYBLUrQpeqnUQ8WItfgIhhEebtsEo9Rg/b0+WHUnrRMs6J8JV4L4MCCPbJ XSWtWLog/Wn213GOo6APX8M4Bypxxul/DDXwyOgQ5PNfe4ltT89tgl50BZZ2NtHkEiky T4U6W7H5iAp49bdF8dYGHMkpQTeWNmDqoZySs43VEvD1XvUG1OD57EUsNmiNjuJursuZ rQTw== X-Gm-Message-State: AGRZ1gIDfiIv0z4rsaEEih0a6OBmZeL555MBqUCPutw1smu9Cx8TrJen Jc83/cruVrraxTac3B7XXz3Wtg== X-Received: by 2002:a2e:215a:: with SMTP id h87-v6mr9407080ljh.102.1540800398714; Mon, 29 Oct 2018 01:06:38 -0700 (PDT) Received: from [192.168.0.126] ([31.173.80.69]) by smtp.gmail.com with ESMTPSA id c22sm2922682lfd.88.2018.10.29.01.06.37 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 29 Oct 2018 01:06:37 -0700 (PDT) Subject: Re: [PATCH] clk: boston: fix possible memory leak in clk_boston_setup() To: Yi Wang , paul.burton@mips.com Cc: mturquette@baylibre.com, sboyd@kernel.org, linux-mips@linux-mips.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, zhong.weidong@zte.com.cn References: <1540800277-24524-1-git-send-email-wang.yi59@zte.com.cn> From: Sergei Shtylyov Message-ID: <5484fe07-5909-dc67-5de6-72e878060a54@cogentembedded.com> Date: Mon, 29 Oct 2018 11:06:41 +0300 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <1540800277-24524-1-git-send-email-wang.yi59@zte.com.cn> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello! On 10/29/2018 11:04 AM, Yi Wang wrote: > 'onecell' is malloced in clk_boston_setup(), but not be freed Is not freed. > before leaving from the error handling cases. > > Signed-off-by: Yi Wang [...] MBR, Sergei