Received: by 2002:ac0:98c7:0:0:0:0:0 with SMTP id g7-v6csp3120123imd; Mon, 29 Oct 2018 01:53:53 -0700 (PDT) X-Google-Smtp-Source: AJdET5fi8epEBIqs+FXUcUBeL3/Kb4KM4W/8hSgWi6FM0N9yAw0mlW3xpJoGAHSebVfTWWMpMMQj X-Received: by 2002:a17:902:14e:: with SMTP id 72-v6mr13135101plb.299.1540803233530; Mon, 29 Oct 2018 01:53:53 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1540803233; cv=none; d=google.com; s=arc-20160816; b=NPk5tlq2yYPdv26gT97oErpkMiY/AGwm1dIYYt1qzPkLMMLMdWwflVAj3mtYHXs1dW Qv9wOiaFCA9YAqmn0NBJTRYbQqGEmUrBniaZvc/P//AD30u0IlkJDJmsFBLxnieQgttU zHWaCpi8mtbTTt2iRpbeKQxS3P8bp1Zzs00gOnWm8BcF3Xn0i7e/ZidRvlnqhnRJ2kUm s1vk9B5vENavmSD7f42ss0x6FXAcNI/QSE2NlBWKrZswbkKIV7BXIfekQHXwyUWp0IJL tJN0H8yEIQWscSN16twrhUi3yguWuVcUo0WMDvDcjbBIDSJ3mr+Sc0+rxaqs2gc1D7I6 7Rzw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=02xQMUKH/pONzrKPMUbCZuHTTDhVek3zIxCCXDzGNDc=; b=zDsWnhnU+6586zwOHHn0mvFi9KtYt/3tKgGtcE1MwK7JWCkenbOyaW4CdAlE8vEppe w56bEZuE6g/tz22iro5nLp7vaMn6y3y6Qz+o2/YLkDFEjS3vpKDbt0dMk6pgWkW3FQIw L0UH8n/QjHa55Zmemtar+VkiJb/UuEyAODOSGcthg2kcr972/wV0A6azV5JfYroPqZCv Fg6q7W9jrsTEkvGpXEKK9ISFUVUBmPnv3QsbowItkNArZsdPVm0or7zZ4HAp5l29hk3I NQjVif/G0EtR1MGu5GnDp2RJwsonrNIXDc3y0rDrDrGhDBFdhnRkfIaW+CyDT6Zo82na p1Lw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id f23-v6si19293635pfn.85.2018.10.29.01.53.38; Mon, 29 Oct 2018 01:53:53 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729468AbeJ2Rkr (ORCPT + 99 others); Mon, 29 Oct 2018 13:40:47 -0400 Received: from sauhun.de ([88.99.104.3]:33228 "EHLO pokefinder.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729391AbeJ2Rkr (ORCPT ); Mon, 29 Oct 2018 13:40:47 -0400 Received: from localhost (unknown [87.114.85.207]) by pokefinder.org (Postfix) with ESMTPSA id 473BE2CF60D; Mon, 29 Oct 2018 09:53:03 +0100 (CET) Date: Mon, 29 Oct 2018 08:53:01 +0000 From: Wolfram Sang To: Peter Korsgaard Cc: Federico Vaga , linux-i2c , linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/3] i2c:ocores: do not handle IRQ if IF is not set Message-ID: <20181029085259.GA4101@kunai> References: <20180625161303.7991-1-federico.vaga@cern.ch> <20180625161303.7991-3-federico.vaga@cern.ch> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="xHFwDpU9dbj6ez1V" Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --xHFwDpU9dbj6ez1V Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sun, Oct 21, 2018 at 04:12:10PM +0200, Peter Korsgaard wrote: > On Mon, Jun 25, 2018 at 6:14 PM Federico Vaga wro= te: > > > > If the Interrupt Flag (IF) is not set, we should not handle the IRQ: > > - the line can be shared with other devices > > - it can be a spurious interrupt > > > > To avoid reading twice the status register, the ocores_process() functi= on > > expects it to be read by the caller. > > > > Signed-off-by: Federico Vaga >=20 > Looks good. >=20 > Acked-by: Peter Korsgaard I assume this patch will be resent when the other patches get updated? Or shall I pick this one independently of the others? --xHFwDpU9dbj6ez1V Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEOZGx6rniZ1Gk92RdFA3kzBSgKbYFAlvWymcACgkQFA3kzBSg KbbkThAAkno+UvEC0fsht0p1uwzti9jL8JMH50loKl1WczNQ4Hp4Te58W9XJEUZf xgPOpFso7/Q5tI0eOHoJOXGxWgpIGXYtxLVuIM1cghRD5XRD+m9UnOMW8XzIoc7R SBpmCFNGuE98fsZ/PUbSADKuiHLV027+iQ2zuAPyIXYAH70v8PerRz7MvxJyKbBE LVnEQjFXOkOGM2ZixZ5ImSEElDHXNpxBlj6H34UC9NgtpkDFp9ToEngYfWXE/5p8 V0dzDuOS7pGFmN9koVlH/7o4CEQ10AMnWeFTBqXcUGc7YDAnu7ywNkXnogFySVLO CiRciV/YY+8l2pTsOlhO+CaTBo8RE0GmbKee2T9oXPlt07eboqKDK2DjfRLxJcyH xfGxUZLgTKaVt1vNAeTtZi0siUXBo2mnHznDbxxMExlanLlCyH93okyEPwFrf23d g4sBfYvMWDIywFlm0XOqfUd6NM1jBu3/jvMMH0I453Yoxg53Bffd7usdbS01tuZR PzJhDgeBXG4xnxrQDI4otHUyTK1w9Cu2hU53tW5H82Pe/gb350hIElODuZnvJc3W +B+G89L01n82xyXFjPN0nsey/n2QriSI5mbf6rSiZE5j17Rl1jt4Zk8t3yPNiqH0 sxuOvuLmrYSrpriJsIJqfvJ486fZeFeyIwjJIEnKvruzZn9COHM= =nbLE -----END PGP SIGNATURE----- --xHFwDpU9dbj6ez1V--