Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH] kdump, vmcoreinfo: Export sme_me_mask value to vmcoreinfo
To:     Baoquan He <bhe@redhat.com>
Cc:     Borislav Petkov <bp@alien8.de>, Petr Tesarik <ptesarik@suse.cz>,
        linux-kernel@vger.kernel.org, x86@kernel.org,
        kexec@lists.infradead.org, mingo@redhat.com, tglx@linutronix.de,
        dyoung@redhat.com
References: <20181026222517.GB26927@nazgul.tnic>
 <20181027081343.GA1884@MiWiFi-R3L-srv> <20181027091007.GB1046@nazgul.tnic>
 <20181027093917.GA14493@MiWiFi-R3L-srv> <20181027101221.GC1046@nazgul.tnic>
 <20181027110858.GB14493@MiWiFi-R3L-srv>
 <C5F8ED8E-F361-4C6C-B9E2-E3C8BCD8E050@alien8.de>
 <c55bef2a-b972-7e6e-b698-6ac1bc736046@redhat.com>
 <20181027145151.GA7338@nazgul.tnic>
 <390b16ba-05d7-3590-c3b2-4b69aa3ae051@redhat.com>
 <20181029083118.GC1884@MiWiFi-R3L-srv>
From:   lijiang <lijiang@redhat.com>
Message-ID: <d6f93848-c750-f29c-4ca7-9661596cad62@redhat.com>
Date:   Mon, 29 Oct 2018 17:29:16 +0800
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.9.1
MIME-Version: 1.0
In-Reply-To: <20181029083118.GC1884@MiWiFi-R3L-srv>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 8bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

在 2018年10月29日 16:31, Baoquan He 写道:
> On 10/29/18 at 03:59pm, lijiang wrote:
>> diff --git a/arch/x86/kernel/machine_kexec_64.c b/arch/x86/kernel/machine_kexec_64.c
>> index 4c8acdfdc5a7..de363796ed20 100644
>> --- a/arch/x86/kernel/machine_kexec_64.c
>> +++ b/arch/x86/kernel/machine_kexec_64.c
>> @@ -29,6 +29,9 @@
>>  #include <asm/setup.h>
>>  #include <asm/set_memory.h>
>>
>> +u64 sme_mask;
>> +EXPORT_SYMBOL(sme_mask);
> 
> Wondering why it is global. Who else will use it?
> 
In general, no need to export the symbol of local variable.

Ok, i will change it to a local variable and export it.

Thanks.
Lianbo

>> +
>>  #ifdef CONFIG_KEXEC_FILE
>>  const struct kexec_file_ops * const kexec_file_loaders[] = {
>>                 &kexec_bzImage64_ops,
>> @@ -357,6 +360,9 @@ void arch_crash_save_vmcoreinfo(void)
>>         vmcoreinfo_append_str("NUMBER(pgtable_l5_enabled)=%d\n",
>>                         pgtable_l5_enabled());
>>
>> +       sme_mask = sme_me_mask;
>> +       VMCOREINFO_NUMBER(sme_mask);
>> +
>>  #ifdef CONFIG_NUMA
>>         VMCOREINFO_SYMBOL(node_data);
>>         VMCOREINFO_LENGTH(node_data, MAX_NUMNODES);