Received: by 2002:ac0:98c7:0:0:0:0:0 with SMTP id g7-v6csp3168392imd; Mon, 29 Oct 2018 02:53:39 -0700 (PDT) X-Google-Smtp-Source: AJdET5dRoLkI24qJHj5HejDyJyAW9IEzBdG4+lrJmJ2I1nMfnpnd3hjoRz/pN9spGzboIR/CvVDP X-Received: by 2002:a17:902:4025:: with SMTP id b34-v6mr9635977pld.318.1540806819590; Mon, 29 Oct 2018 02:53:39 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1540806819; cv=none; d=google.com; s=arc-20160816; b=ay9a4V+i2n++vMdJ9Z1nhGIKUmTn+ObKHyUNjwYyyqWvfQv5sqQ2/LM+dLfWvBAEh3 4GqTByJo6sn422vKEUaLzoKRU+YzWWN88SI5tinSOUX51kBcPkQhCaUXAeDCJiLKaNg+ 74xpu3mBWck1HZBbGwMKncRbGAT4JNXM6o/nzOjrjiBJV4Kqm+1KeYltiKw7o4N8rghM 121zlG6PVvXaKHhMq0eFxXZwqLbMS6l/rIWjJLvcsaHpxg3Psl+jrku7Hy2lqSqkRpg1 xP9MfXiN+g9nCG2gA454LA3JWFlfGgQIN7VTi02YE+E0dfM1FgI8yLPwNFLE9pUvoGog EPrg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :organization:references:in-reply-to:message-id:subject:cc:to:from :date; bh=8RNudNQIVAdOAM+u1NezPgwaRBkzI2oDgMa+Uggm4tU=; b=LrF7hNghtBjfmDhnusDKCm2zhxo5dexqfSMY/G/TZtuZSx+d8Jy6xzC7Yt70c6ZJFh f+cbqQ4qHZRb2iP4OMHWUtEMe+AmyWNBlhFYk0HPMRDVoj1gw/pFhtScp8A/QBk2WZcF HFoDxcUJa+j2KGTo+xpHFK8FrNsqMr611t85MmcXcJ2NtSEJDwrlsM+y1bioi9hAg1hZ e9910MVN41CpU+ym5OsOBKacQkOdjhwvoIpDhyENOGWla7aahCjqUaJFD7itGL3Jgt0C xtrzfEvA8HhYFdusCezoL3xReAmgRM6Anu1Nek2CMwulzcS/KaccTZUSqzY1go+yRIZa HLsw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id m39-v6si19404877plg.335.2018.10.29.02.53.23; Mon, 29 Oct 2018 02:53:39 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729792AbeJ2SjP convert rfc822-to-8bit (ORCPT + 99 others); Mon, 29 Oct 2018 14:39:15 -0400 Received: from mail.bootlin.com ([62.4.15.54]:57519 "EHLO mail.bootlin.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729459AbeJ2SjP (ORCPT ); Mon, 29 Oct 2018 14:39:15 -0400 Received: by mail.bootlin.com (Postfix, from userid 110) id 9E4F7207D4; Mon, 29 Oct 2018 10:51:18 +0100 (CET) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on mail.bootlin.com X-Spam-Level: X-Spam-Status: No, score=-1.0 required=5.0 tests=ALL_TRUSTED,SHORTCIRCUIT shortcircuit=ham autolearn=disabled version=3.4.0 Received: from xps13 (aaubervilliers-681-1-12-210.w90-88.abo.wanadoo.fr [90.88.133.210]) by mail.bootlin.com (Postfix) with ESMTPSA id 5576B20901; Mon, 29 Oct 2018 10:51:08 +0100 (CET) Date: Mon, 29 Oct 2018 10:51:08 +0100 From: Miquel Raynal To: Naga Sureshkumar Relli Cc: , , , , , , , , Subject: Re: [LINUX PATCH v11 0/3] Add support for Arasan NAND Flash controller Message-ID: <20181029105108.562ddd21@xps13> In-Reply-To: <1537878031-22253-1-git-send-email-naga.sureshkumar.relli@xilinx.com> References: <1537878031-22253-1-git-send-email-naga.sureshkumar.relli@xilinx.com> Organization: Bootlin X-Mailer: Claws Mail 3.16.0 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Naga, Naga Sureshkumar Relli wrote on Tue, 25 Sep 2018 17:50:28 +0530: > This patch series adds the basic driver support for Arasan NAND Flash controller. > We are reinitiating the patch series by fixing the comments given by Miquel and Boris. > Major changes are exec_op() implementation related. > Rebased to 4.19 nand tree. > Tested MT29F32G08ABCDBJ4. > > As suggested by Boris, it also adds a new varaible called mode in > struct nand_sdr_timings, which will give directly the sdr operating > mode. and it is useful for some controllers, where we can configure > direclty the operating mode instead of timings. > Unless I missed something there are still comments from Boris pending? I will wait for your v12 to give this driver another shot. Thanks, Miquèl