Received: by 2002:ac0:98c7:0:0:0:0:0 with SMTP id g7-v6csp3215375imd; Mon, 29 Oct 2018 03:44:02 -0700 (PDT) X-Google-Smtp-Source: AJdET5c3Sz5d2pBxk776Ab/pYujsaBLt9wo4kBAa59K62UHJl1APl05oEb930Vi+P++onhJRemgR X-Received: by 2002:a63:ce56:: with SMTP id r22-v6mr13128817pgi.217.1540809842152; Mon, 29 Oct 2018 03:44:02 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1540809842; cv=none; d=google.com; s=arc-20160816; b=XRRj/NDOuwptZyzF46UMCOWPZTNaxpKFsCvm2ft49YaZbEpEDz28zNkL+qyKiz4te0 DeLn1Ea1OqDqucFZ2/O32wd+E/Jeezsz5qfqJZ4ITSnmKx9nzcFZ6V6QGKaGS7r+Gstu WdQks02Qz/FJx1uEvjQ0ZzjyluTnnG4Ixefm+q/OfST3MWZ0bwDEyYId1E/OSkLV6V6l agrMKwfivwMIEtuytXsVvxADzva/Imi/Q2sLojVGL2DKMJytwu5pd4uxd3Pru/vnpTIy EmPK7zRWghGM1OuUAoiqNytX3DTeFASC31nLM1FzdMCqdDw7hUvKhGEE6848SK1LMTlR wCQw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=7gE7E5jBkT6tAFFhPHr2gl+EYijqje/NF1QlroALHko=; b=IEgFO7SHmZgZiwVmwu4iCWVafnxKLgSfAr2tzOxEBUblT/dVfBBYyy6jskcgB8JEVf wQB9gaVrBsRsB3/KlOuy6mpc6mvR4My+9TCty79iiqoJG9HLqbCPg1Be6wRfcwXNaX2R UAyTVev2mQegMJ6QVWyWvtQt7wItDe5qBD0DkQ/EuuUowNdY0NpTmAeeLbYVxCD9CiAd 2MvEazTZSxJZX7QEM4pHq94vHO7XsPw/3TSniv39qtQ2NwC8IsfCja0YG2uXrdx1OwSu APeCXKoajEs44EdVda+FuMeYpDlZU+lE7iC4ugdpT8j64zvryulbHnmu69ACYh8AyYPT i7cw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id d7-v6si19178247pgn.441.2018.10.29.03.43.46; Mon, 29 Oct 2018 03:44:02 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729648AbeJ2Tbb (ORCPT + 99 others); Mon, 29 Oct 2018 15:31:31 -0400 Received: from foss.arm.com ([217.140.101.70]:38650 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729208AbeJ2Tbb (ORCPT ); Mon, 29 Oct 2018 15:31:31 -0400 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id E1D8D165C; Mon, 29 Oct 2018 03:43:24 -0700 (PDT) Received: from arrakis.emea.arm.com (arrakis.cambridge.arm.com [10.1.196.80]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 462BA3F6A8; Mon, 29 Oct 2018 03:43:23 -0700 (PDT) Date: Mon, 29 Oct 2018 10:43:20 +0000 From: Catalin Marinas To: Prateek Patel Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-tegra@vger.kernel.org, snikam@nvidia.com, vdumpa@nvidia.com, talho@nvidia.com, swarren@nvidia.com, Sri Krishna chowdary Subject: Re: [PATCH V2] kmemleak: Add config to select auto scan Message-ID: <20181029104320.GC168424@arrakis.emea.arm.com> References: <1540231723-7087-1-git-send-email-prpatel@nvidia.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1540231723-7087-1-git-send-email-prpatel@nvidia.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Oct 22, 2018 at 11:38:43PM +0530, Prateek Patel wrote: > From: Sri Krishna chowdary > > Kmemleak scan can be cpu intensive and can stall user tasks at times. > To prevent this, add config DEBUG_KMEMLEAK_AUTO_SCAN to enable/disable > auto scan on boot up. > Also protect first_run with DEBUG_KMEMLEAK_AUTO_SCAN as this is meant > for only first automatic scan. > > Signed-off-by: Sri Krishna chowdary > Signed-off-by: Sachin Nikam > Signed-off-by: Prateek Looks fine to me. Reviewed-by: Catalin Marinas