Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH] lightnvm: pblk: fix chunk close trace event check
To:     hans@owltronix.com
Cc:     linux-block@vger.kernel.org, javier@cnexlabs.com,
        linux-kernel@vger.kernel.org, hans.holmberg@cnexlabs.com
References: <1540541544-7761-1-git-send-email-hans.holmberg@cnexlabs.com>
 <e884c6c9-d875-e282-59dd-f1733ffc38fb@lightnvm.io>
 <CANr-nt0kcMYrGA5fmG1HBG+Hp6DUwi7B+SWTVfjYtHYE5EGELw@mail.gmail.com>
From:   =?UTF-8?Q?Matias_Bj=c3=b8rling?= <mb@lightnvm.io>
Message-ID: <35331f13-983b-fb96-3885-f4e617c4adee@lightnvm.io>
Date:   Mon, 29 Oct 2018 12:14:22 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.9.1
MIME-Version: 1.0
In-Reply-To: <CANr-nt0kcMYrGA5fmG1HBG+Hp6DUwi7B+SWTVfjYtHYE5EGELw@mail.gmail.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-GB
Content-Transfer-Encoding: 8bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On 10/29/2018 10:56 AM, Hans Holmberg wrote:
> On Fri, Oct 26, 2018 at 8:49 PM Matias Bjørling <mb@lightnvm.io> wrote:
>>
>> On 10/26/2018 10:12 AM, Hans Holmberg wrote:
>>> The check for chunk closes suffers from an off-by-one issue, leading
>>> to chunk close events not being traced. Fix this.
>>>
>>> Fixes: 4c44abf43d00 ("lightnvm: pblk: add trace events for chunk states")
>>>
>>> Signed-off-by: Hans Holmberg <hans.holmberg@cnexlabs.com>
>>> ---
>>>
>>>    drivers/lightnvm/pblk-core.c | 2 +-
>>>    1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/drivers/lightnvm/pblk-core.c b/drivers/lightnvm/pblk-core.c
>>> index 6944aac43b01..6581c35f51ee 100644
>>> --- a/drivers/lightnvm/pblk-core.c
>>> +++ b/drivers/lightnvm/pblk-core.c
>>> @@ -531,7 +531,7 @@ void pblk_check_chunk_state_update(struct pblk *pblk, struct nvm_rq *rqd)
>>>                if (caddr == 0)
>>>                        trace_pblk_chunk_state(pblk_disk_name(pblk),
>>>                                                        ppa, NVM_CHK_ST_OPEN);
>>> -             else if (caddr == chunk->cnlb)
>>> +             else if (caddr == (chunk->cnlb - 1))
>>>                        trace_pblk_chunk_state(pblk_disk_name(pblk),
>>>                                                        ppa, NVM_CHK_ST_CLOSED);
>>>        }
>>>
>>
>> Thanks Hans, Applied for 4.21/5.1. Note that you're sending from your
>> owntronix email account. Checkpatch complains that sender and author
>> doesn't match.
> 
> Ah, I must have messed up my git configuration.
> Would you mind updating the patch author to "Hans Holmberg
> <hans.holmberg@cnexlabs.com>" in for-4.21/core?
> 
> Thanks,
> Hans
> 

Will do. Thanks.