Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
To:     Yi Wang <wang.yi59@zte.com.cn>, paul.burton@mips.com
From:   Stephen Boyd <sboyd@kernel.org>
In-Reply-To: <1540801907-31544-1-git-send-email-wang.yi59@zte.com.cn>
Cc:     mturquette@baylibre.com, linux-mips@linux-mips.org,
        linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org,
        zhong.weidong@zte.com.cn, Yi Wang <wang.yi59@zte.com.cn>
References: <1540801907-31544-1-git-send-email-wang.yi59@zte.com.cn>
Message-ID: <154083382731.98144.10932242759017894372@swboyd.mtv.corp.google.com>
User-Agent: alot/0.7
Subject: Re: [PATCH v2] clk: boston: fix possible memory leak in clk_boston_setup()
Date:   Mon, 29 Oct 2018 10:23:47 -0700
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Quoting Yi Wang (2018-10-29 01:31:47)
> 'onecell' is malloced in clk_boston_setup(), but is not freed
> before leaving from the error handling cases.

How did you find this? Visual inspection? Some coccinelle script?

> =

> Signed-off-by: Yi Wang <wang.yi59@zte.com.cn>
> ---
> v2: fix syntax issue in comment, thanks to  Sergei.
> =

>  drivers/clk/imgtec/clk-boston.c | 11 ++++++++---
>  1 file changed, 8 insertions(+), 3 deletions(-)
> =

> diff --git a/drivers/clk/imgtec/clk-boston.c b/drivers/clk/imgtec/clk-bos=
ton.c
> index 15af423..f5d54a6 100644
> --- a/drivers/clk/imgtec/clk-boston.c
> +++ b/drivers/clk/imgtec/clk-boston.c
> @@ -73,27 +73,32 @@ static void __init clk_boston_setup(struct device_nod=
e *np)
>         hw =3D clk_hw_register_fixed_rate(NULL, "input", NULL, 0, in_freq=
);
>         if (IS_ERR(hw)) {
>                 pr_err("failed to register input clock: %ld\n", PTR_ERR(h=
w));
> -               return;
> +               goto error;
>         }
>         onecell->hws[BOSTON_CLK_INPUT] =3D hw;
>  =

>         hw =3D clk_hw_register_fixed_rate(NULL, "sys", "input", 0, sys_fr=
eq);
>         if (IS_ERR(hw)) {
>                 pr_err("failed to register sys clock: %ld\n", PTR_ERR(hw)=
);
> -               return;
> +               goto error;
>         }
>         onecell->hws[BOSTON_CLK_SYS] =3D hw;
>  =

>         hw =3D clk_hw_register_fixed_rate(NULL, "cpu", "input", 0, cpu_fr=
eq);
>         if (IS_ERR(hw)) {
>                 pr_err("failed to register cpu clock: %ld\n", PTR_ERR(hw)=
);
> -               return;
> +               goto error;
>         }
>         onecell->hws[BOSTON_CLK_CPU] =3D hw;
>  =

>         err =3D of_clk_add_hw_provider(np, of_clk_hw_onecell_get, onecell=
);
>         if (err)
>                 pr_err("failed to add DT provider: %d\n", err);
> +
> +       return;
> +
> +error:
> +       kfree(onecell);

Ok, sure. But then clks are still left registered on failure?