To: linux-kernel@vger.kernel.org
From: mru@kth.se (=?iso-8859-1?q?M=E5ns_Rullg=E5rd?=)
Subject: Re: GCC 3.4 Heads-up
Date: Mon, 05 Jan 2004 02:38:54 +0100
Message-ID: <yw1xu13b2mz5.fsf@ford.guide>
References: <bsgav5$4qh$1@cesium.transmeta.com> <Pine.LNX.4.58.0312252021540.14874@home.osdl.org>
 <3FF5E952.70308@tmr.com> <m365fsu48n.fsf@defiant.pm.waw.pl>
 <3FF7A910.40703@tmr.com> <Pine.LNX.4.58.0401041232440.2162@home.osdl.org>
 <3FF8BDBB.4060708@tmr.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Transfer-Encoding: 8bit
User-Agent: Gnus/5.1002 (Gnus v5.10.2) XEmacs/21.4 (Rational FORTRAN, linux)
Cancel-Lock: sha1:L+7pdF/35qCXsKO94EZmWPMQ7J8=
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1022
Lines: 29

Bill Davidsen <davidsen@tmr.com> writes:

>> If you have local variables (register or not), the sane thing to do is
>> 	if (a)
>> 		b = d;
>> 	else
>> 		c = d;
>> or variations on that. That's the readable code.
>
> But may lead to errors in maintenence. Your first example below avoids
> that problem. Imagine instead of "d" you have a 40-50 character
> RHS. Now imagine that the code needs to be changed. If you have the
> long expression in two places then it invites the possiblility of
> someone changing only one of them. You may never make mistakes, but
> the rest of us do, and the conditional LHS avoids that.

What's wrong with

	d = long_expression;
 	if (a)
 		b = d;
 	else
 		c = d;

Your long expression is still only in one place.

-- 
M?ns Rullg?rd
mru@kth.se

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/