Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
To:     Dean Wallace <duffydack73@gmail.com>,
        Hans de Goede <hdegoede@redhat.com>
From:   Stephen Boyd <sboyd@kernel.org>
In-Reply-To: <20181025232517.ywnw54qibemosjws@picard>
Cc:     mturquette@baylibre.com, linux-clk@vger.kernel.org,
        stable@vger.kernel.org, Johannes Stezenbach <js@sig21.net>,
        Carlo Caione <carlo@endlessm.com>,
        Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
        linux-kernel@vger.kernel.org
References: <20181025232517.ywnw54qibemosjws@picard>
Message-ID: <154083512089.98144.9141070901932719147@swboyd.mtv.corp.google.com>
User-Agent: alot/0.7
Subject: Re: Regression found (Stop-marking-clocks-as-CLK_IS_CRITICAL)
Date:   Mon, 29 Oct 2018 10:45:20 -0700
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Quoting Dean Wallace (2018-10-25 16:25:17)
> I have found a regression in 4.18.15 that means I lose sound on my old
> Toshiba Chromebook 2 (Swanky).  My system details are:-
> =

> Toshiba Chromebook (Swanky)
> MrChromebox UEFI coreboot
> Arch Linux running latest alsa/pulseaudio
> =

> Upgraded kernel from 4.18.14 to 4.18.15 and lost all sound output.  By
> output I mean, the card is still detected, the module loaded, all apps
> showing sound is being playing, but no actual audible sound comes
> through.  Upgraded to 4.18.16 same issue.
> =

> Dug around and found Upstream commit 648e921888ad96ea3dc922739e96716ad322=
5d7f
> clk: x86: Stop marking clocks as CLK_IS_CRITICAL
> "This commit removes the CLK_IS_CRITICAL marking, fixing Cherry Trail
> devices not being able to reach S0i3 greatly decreasing their battery
> drain when suspended."
> =

> I reverted it and compiled 4.18.16 and have sound back again.  Could
> this be looked into, with possibility of fix.
> =


Thanks for the bug report. I'm adding some people involved in the commit
you mention is causing audio regressions. The best plan is to probably
revert the commit from the 4.18 linux stable tree. Or there may be
another patch missing that would be useful to make this backported patch
work. Hopefully Hans or Andy knows.