Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Tue, 30 Oct 2018 13:09:00 +0800
From:   Dave Young <dyoung@redhat.com>
To:     lijiang <lijiang@redhat.com>
Cc:     Borislav Petkov <bp@alien8.de>, Baoquan He <bhe@redhat.com>,
        Petr Tesarik <ptesarik@suse.cz>, linux-kernel@vger.kernel.org,
        x86@kernel.org, kexec@lists.infradead.org, mingo@redhat.com,
        tglx@linutronix.de
Subject: Re: [PATCH] kdump, vmcoreinfo: Export sme_me_mask value to vmcoreinfo
Message-ID: <20181030050900.GA25987@dhcp-128-65.nay.redhat.com>
References: <20181027145151.GA7338@nazgul.tnic>
 <390b16ba-05d7-3590-c3b2-4b69aa3ae051@redhat.com>
 <20181029083118.GC1884@MiWiFi-R3L-srv>
 <d6f93848-c750-f29c-4ca7-9661596cad62@redhat.com>
 <20181029095738.GB20101@zn.tnic>
 <15897206-c1a6-ced6-3a1b-f71da8fc9c83@redhat.com>
 <20181029114414.GA11408@MiWiFi-R3L-srv>
 <90385882-7fd1-a674-ec5a-19bd42471a5e@redhat.com>
 <20181029134918.GB32150@zn.tnic>
 <699ab34e-1373-582d-4e58-e76bd57ec34f@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <699ab34e-1373-582d-4e58-e76bd57ec34f@redhat.com>
User-Agent: Mutt/1.9.5 (2018-04-13)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On 10/30/18 at 12:46pm, lijiang wrote:
> 在 2018年10月29日 21:49, Borislav Petkov 写道:
> > On Mon, Oct 29, 2018 at 09:41:26PM +0800, lijiang wrote:
> >>>         VMCOREINFO_NUMBER(phys_base);
> >>>         VMCOREINFO_SYMBOL(init_top_pgt);
> >>>         vmcoreinfo_append_str("NUMBER(pgtable_l5_enabled)=%d\n",
> >>>                         pgtable_l5_enabled());
> >>>
> >>> +       VMCOREINFO_NUMBER(sme_mask);
> > 
> > What I'm still missing from the whole fun is where are we documenting
> > the contents of that vmcoreinfo thing?
> > 
> 
> I'm not sure whether the following document is what you need.
> Documentation/ABI/testing/sysfs-kernel-vmcoreinfo

It is not the content, I think it is a good catch from Boris, it would
be good to document the exported things in somewhere eg.
Documentation/kdump/vmcoreinfo.txt

> 
> Thanks.
> Lianbo
> > If not, we need it documented.
> > 

Thanks
Dave