Received: by 2002:ac0:98c7:0:0:0:0:0 with SMTP id g7-v6csp4470828imd; Tue, 30 Oct 2018 02:28:14 -0700 (PDT) X-Google-Smtp-Source: AJdET5cX1MfdjgJO+OSyf4KKU5na4tQcHXsZWCCz0xC5FLtyO1OJRpmoODuI6RwtKj4n427W9RIV X-Received: by 2002:a63:374e:: with SMTP id g14mr17510499pgn.59.1540891694858; Tue, 30 Oct 2018 02:28:14 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1540891694; cv=none; d=google.com; s=arc-20160816; b=uqezvyTDays/LCGTWSTxhhweyZtrX6FPbExRyr6LZ9i9ImnOGQfe/y2vVi55a4is7u G34G05KJp9Eu0lJzFuMvlEjtUt/uTHXkDM4BoXecvwbt9z1ae10V2npM345weFcdW/C1 pIkkeJ/QiTV3lPyniMSDtyn6+sYgGWyQoa+Wi/9f0of6w6q/imqo4irJiKB5PsEROw7n YviTPZ0D/pGvq52FlaHcKrn5A9k7g37wpP+LLATnwZuWu5cKiRPvxcvsi8IhjMg2F5vB uNdRWR5jZrL/ixikR8ZnzDN1aiXRkF0cUjxkV+R+QeUn6Xq0RzuBwu/K+m2EIGEjN9Ms I/dw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=O2HU6VDGLjtO9kbUG+BX1qUMZ4Rr1hIhsue1c5NFAM4=; b=sUxzyKK0pgQL+fcKVkQ9Kqwm5yEoqXG6vs7zXZrgIaq1+UeMWHUI1Wj8skCk4u+wV2 4u9loqU0ehUeUq2VZQb6ofbOB04a8TlJLT1muvQgccDQUaD4HTPLAhqY6uQ5qoGEzzCh sDvN+v7pq0HLxxOy3FT5GqF5ednIuqR9XG0S4/Uis31Lnj/+z80xu5Eizq3SCU9SV1ah +2LFPBnaEwXDx8BhQJMSIzZwLhPPP0uCEBJRDJIHtNft8PvPJiN9/1RWpUchlhmkbLV/ 7xZj5s4RSH9e4Edb4hxiNhtorJ6McVA7MCnmd1ysZn5QYbIFPEkA7Cao1e+EuXunlEyS 5law== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 33-v6si6358326pld.296.2018.10.30.02.27.59; Tue, 30 Oct 2018 02:28:14 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727339AbeJ3STp (ORCPT + 99 others); Tue, 30 Oct 2018 14:19:45 -0400 Received: from mx1.redhat.com ([209.132.183.28]:49018 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726486AbeJ3STp (ORCPT ); Tue, 30 Oct 2018 14:19:45 -0400 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 0D95A307CDDA; Tue, 30 Oct 2018 09:27:06 +0000 (UTC) Received: from krava (unknown [10.43.17.150]) by smtp.corp.redhat.com (Postfix) with SMTP id EFBB61000049; Tue, 30 Oct 2018 09:27:04 +0000 (UTC) Date: Tue, 30 Oct 2018 10:27:03 +0100 From: Jiri Olsa To: Jiri Olsa Cc: lkml , "Signed-off-by : Len Brown" , "Herton R. Krzesinski" Subject: Re: [PATCH 05/10] tools power x86_energy_perf_policy: Override CFLAGS assignments and add LDFLAGS to build command Message-ID: <20181030092703.GB19259@krava> References: <20181016150614.21260-1-jolsa@kernel.org> <20181016150614.21260-6-jolsa@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20181016150614.21260-6-jolsa@kernel.org> User-Agent: Mutt/1.10.1 (2018-07-13) X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.49]); Tue, 30 Oct 2018 09:27:06 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org ping thanks, jirka On Tue, Oct 16, 2018 at 05:06:10PM +0200, Jiri Olsa wrote: > So user could specify outside CFLAGS/LDFLAGS values. > > Cc: Signed-off-by: Len Brown > Signed-off-by: Jiri Olsa > --- > tools/power/x86/x86_energy_perf_policy/Makefile | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/tools/power/x86/x86_energy_perf_policy/Makefile b/tools/power/x86/x86_energy_perf_policy/Makefile > index f4534fb8b951..ae7a0e09b722 100644 > --- a/tools/power/x86/x86_energy_perf_policy/Makefile > +++ b/tools/power/x86/x86_energy_perf_policy/Makefile > @@ -9,12 +9,12 @@ ifeq ("$(origin O)", "command line") > endif > > x86_energy_perf_policy : x86_energy_perf_policy.c > -CFLAGS += -Wall > -CFLAGS += -DMSRHEADER='"../../../../arch/x86/include/asm/msr-index.h"' > +override CFLAGS += -Wall > +override CFLAGS += -DMSRHEADER='"../../../../arch/x86/include/asm/msr-index.h"' > > %: %.c > @mkdir -p $(BUILD_OUTPUT) > - $(CC) $(CFLAGS) $< -o $(BUILD_OUTPUT)/$@ > + $(CC) $(CFLAGS) $< -o $(BUILD_OUTPUT)/$@ $(LDFLAGS) > > .PHONY : clean > clean : > -- > 2.17.2 >