Received: by 2002:ac0:98c7:0:0:0:0:0 with SMTP id g7-v6csp4474600imd; Tue, 30 Oct 2018 02:32:35 -0700 (PDT) X-Google-Smtp-Source: AJdET5e9J2/Q1bMdidfW6SMlFAtA8LADmdY2ZRQlC+hr9scanmS80zgDHNPLkFBaQby6uAQqof8u X-Received: by 2002:a62:7893:: with SMTP id t141-v6mr2124522pfc.259.1540891955765; Tue, 30 Oct 2018 02:32:35 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1540891955; cv=none; d=google.com; s=arc-20160816; b=tDGghN0v9AL9xjgb9uG3Xa6W293/zQOlUzscdkjfYuUlKU5Xs66WCwuQKJ6FBi1VzW uNZB8Jw07G2RsvkRrYf+c85lXFyzk+2PFgOHXX9CplffZG24REdWWWuSkEI/dEzoxOwH FKSI2m15U8IH/6Z9F6180iT4ik53dY3QmRiSJ03PG+F+2LWSwOFOsMvlIX8fOVsBo1CC 74DXBpDzAvejJ+b0fSpLuVAvWMEk8xhXKpJ78BWGIWlhWipMsKV4SJ8qRQe7ZoBauwGT eiVHPCZtiKjYdZIbqq/mekwcxI8kRBUpptoCKxQKZAm84h+B9y4ZgnkIgzyL6yL9777h IRug== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:date:subject:cc:to:from; bh=XSXbUt8UstFXOnUYwKt4d8cJSHiIqTMJVCPeTWhqE1A=; b=gP65OAmRGqlDXDpNde+cPn8qaMP3VduNPZYT/qTpnllhbdYh81a5CFgLrki+xfe1rM fKAN4V6tbUzBf4FrSkmnBIhQpB/O0byQxktViqGEMH0ufDY/x+fWQA5OtnGk1SKYJO56 1f4LLc/+wJcGCHCRIDZsi3x40tLR237Emz8tnKV8AAGtc/sblCG9o9eKJKwDfP9JTTKn XrPlrqH5EdiO3zUWmJqumvD7xuYZgdPpgDFbJ2OfbhBu7vz+yfidTbxZdPGARl2d/uA8 PWZN7i/dMBsZYxweclHUZEacNx9g+upDNPfkBqNzpfM4UfT28Yr3FMTlTA2m0Ro5j7zE ogbw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id z71si6767031pgd.490.2018.10.30.02.32.19; Tue, 30 Oct 2018 02:32:35 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727256AbeJ3SYe (ORCPT + 99 others); Tue, 30 Oct 2018 14:24:34 -0400 Received: from Galois.linutronix.de ([146.0.238.70]:53432 "EHLO Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726212AbeJ3SYd (ORCPT ); Tue, 30 Oct 2018 14:24:33 -0400 Received: from hsi-kbw-5-158-153-52.hsi19.kabel-badenwuerttemberg.de ([5.158.153.52] helo=kurt.tec.linutronix.de) by Galois.linutronix.de with esmtpsa (TLS1.2:DHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.80) (envelope-from ) id 1gHQNA-0003Lk-RP; Tue, 30 Oct 2018 10:31:40 +0100 From: Kurt Kanzenbach To: Anirudha Sarangi , John Linn , "David S. Miller" Cc: Michal Simek , Radhey Shyam Pandey , Andrew Lunn , YueHaibing , netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Kurt Kanzenbach Subject: [PATCH 0/2] net: xlinx: mdio: recheck condition after timeout Date: Tue, 30 Oct 2018 10:31:37 +0100 Message-Id: <20181030093139.10226-1-kurt@linutronix.de> X-Mailer: git-send-email 2.11.0 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, the Xilinx mdio wait functions may return false positives under certain circumstances: If the functions get preempted between reading the corresponding mdio register and checking for the timeout, they could falsely indicate a timeout. In order to avoid the issue, the condition should be rechecked in the timeout case. Kurt Kanzenbach (2): net: axienet: recheck condition after timeout in mdio_wait() net: xilinx_emaclite: recheck condition after timeout in mdio_wait() drivers/net/ethernet/xilinx/xilinx_axienet_mdio.c | 21 ++++++++++++++++----- drivers/net/ethernet/xilinx/xilinx_emaclite.c | 20 +++++++++++++++----- 2 files changed, 31 insertions(+), 10 deletions(-) -- 2.11.0