Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <git-mailbomb-linux-master-5c83511bdb9832c86be20fb86b783356e2f58062@kernel.org>
 <CAB9dFdtLHkpZqrmNEuMfPdOmZm32q5SXYx1zMexSd94rt3KyDw@mail.gmail.com> <d8d4b1bd-2b80-ae4c-18f3-3d2957409500@suse.com>
In-Reply-To: <d8d4b1bd-2b80-ae4c-18f3-3d2957409500@suse.com>
From:   Marc Dionne <marc.dionne@auristor.com>
Date:   Tue, 30 Oct 2018 10:33:38 -0300
Message-ID: <CAB9dFdtw1_YuBXUY3Rb74WisR1iipZK+Sm60pD4cvcrYvbZb6w@mail.gmail.com>
Subject: Re: x86/paravirt: Use a single ops structure
To:     jgross@suse.com
Cc:     Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        Thomas Gleixner <tglx@linutronix.de>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Mon, Oct 29, 2018 at 11:25 AM Juergen Gross <jgross@suse.com> wrote:
>
> On 29/10/2018 13:58, Marc Dionne wrote:
> > On Tue, Oct 23, 2018 at 2:37 PM Linux Kernel Mailing List
> > <linux-kernel@vger.kernel.org> wrote:
> >>
> >> Commit:     5c83511bdb9832c86be20fb86b783356e2f58062
> >> Parent:     27876f3882fdd4acb3d3614a0133ecdc777fc292
> >> Refname:    refs/heads/master
> >> Web:        https://git.kernel.org/torvalds/c/5c83511bdb9832c86be20fb86b783356e2f58062
> >> Author:     Juergen Gross <jgross@suse.com>
> >> AuthorDate: Tue Aug 28 09:40:19 2018 +0200
> >> Committer:  Thomas Gleixner <tglx@linutronix.de>
> >> CommitDate: Mon Sep 3 16:50:35 2018 +0200
> >>
> >>     x86/paravirt: Use a single ops structure
> >>
> >>     Instead of using six globally visible paravirt ops structures combine
> >>     them in a single structure, keeping the original structures as
> >>     sub-structures.
> >>
> >>     This avoids the need to assemble struct paravirt_patch_template at
> >>     runtime on the stack each time apply_paravirt() is being called (i.e.
> >>     when loading a module).
> >
> > The above commit replaces pv_lock_ops, which was EXPORT_SYMBOL, with
> > something that is part of pv_ops, which is EXPORT_SYMBOL_GPL.    When
> > CONFIG_PARAVIRT_SPINLOCKS is set, this has the side effect of making
> > spin_lock() unusable by out of tree modules, which will likely be an
> > issue for many, if not most of them.
>
> Thanks for noticing!
>
> Sending a patch soon...
>
>
> Juergen

Thanks for the quick patch.  Does this also need fixing for arm/arm64?
I can't easily verify but it seems like it would have the same issue.

Marc