Received: by 2002:ac0:98c7:0:0:0:0:0 with SMTP id g7-v6csp4728942imd; Tue, 30 Oct 2018 06:38:22 -0700 (PDT) X-Google-Smtp-Source: AJdET5fiaQOjJIWK6S3ApCEGVE8gsQDuubNvvrB7n5v3DpzCImFMVMj2w514aJby22I7cc1FRsV5 X-Received: by 2002:a63:e818:: with SMTP id s24-v6mr17366010pgh.90.1540906702188; Tue, 30 Oct 2018 06:38:22 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1540906702; cv=none; d=google.com; s=arc-20160816; b=GIRGZApRp8a0aQuRWhrT7GtzVr6JpJSZnDrueA22wG67kPmfoWvbaEUQc/eSDthxAt fgZSAqkmxOuP0lkSIc3XiBG7Cm38I51uPn9jb3DVVBNYeO0BWI5/97IZmjy0xoEtAkvN 0ePbt29Mmd8xRF6kwhe5um1YB/P2awzzBvLhc88nw+MxKYiwN5MMgLt71TktBnsrK2qN oT1MeLxDDIsnti4lFx9CRYzqACc7fsURxpsxtvk7FluS3RjLTvmZgM1ehSKREV7vGnHt tIpRNvnPrAkpTxKDZN4ljoO/Q2edNW2PvGfsfTuyU0aLTzc9IdmYd/ItHq9xDh4JoCYG IiFQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=q10zHlYp7vBnwdroA7chQcvxtiJ4F67FFdb4wdJJlJo=; b=wMwuqeoGPUmLYhjlTg5yjtx/6pDrnRdbRy7ijOl3RPpVKeHJjREmuFiC6R0B5tMGUR 0gjdyoktJiF4QtgF18JFpIdoXLiA0mBUDfhUfXIlimOvXbb6pLVWCDdN4So3tEW0TVv5 zFHEexFYQXYEPha3ixp0++gS4gvwyINnX23LBb74L8QuVGjO/ZYH0tLbQ5jBmTip8quV 3OcT8a79v8KefvywdmR9O33E9/zcZOBrv7T/i9RaI78wN+qb5jx+XwcZkpCxzsV5S2GV sBQWEMsr+oBsTpk7Y9nZVenE7KuvDD46dEaeecsJYZeFosSX0+BK+tPODXG96l8pvgsD c+Fw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=knwr3fYf; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id d34-v6si8923053pla.33.2018.10.30.06.38.01; Tue, 30 Oct 2018 06:38:22 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=knwr3fYf; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728260AbeJ3W2N (ORCPT + 99 others); Tue, 30 Oct 2018 18:28:13 -0400 Received: from mail.kernel.org ([198.145.29.99]:55590 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727750AbeJ3W2N (ORCPT ); Tue, 30 Oct 2018 18:28:13 -0400 Received: from localhost (173-25-171-118.client.mchsi.com [173.25.171.118]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 6607D205F4; Tue, 30 Oct 2018 13:34:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1540906483; bh=w2fIw8gviP+4peuZbmW4Tc0h04KLRmJDwAhYrkSLOTE=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=knwr3fYfRiIWFWglIOV+fNc9gYhDYJNdBFJ7/wVL79ahpL3WGve7rscsknxWfEUyQ yyh1UWnLziGPCMdnWqs9euVUypjuZWtj9hKQtaJav1Hgf52OQvRlEXtmrHytw5CZjG dxHPKdnK836Glt3FJnQg/50DIYVeD+7gP/tImrCU= Date: Tue, 30 Oct 2018 08:34:42 -0500 From: Bjorn Helgaas To: Suganath Prabu Cc: lukas@wunner.de, linux-scsi@vger.kernel.org, linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, benh@kernel.crashing.org, ruscur@russell.cc, sbobroff@linux.ibm.com, oohall@gmail.com, andy.shevchenko@gmail.com, Sathya.Prakash@broadcom.com, sreekanth.reddy@broadcom.com Subject: Re: [v6 3/4] mpt3sas:Fix driver modifying persistent data. Message-ID: <20181030133442.GC41022@google.com> References: <1540290081-15827-1-git-send-email-suganath-prabu.subramani@broadcom.com> <1540290081-15827-4-git-send-email-suganath-prabu.subramani@broadcom.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1540290081-15827-4-git-send-email-suganath-prabu.subramani@broadcom.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Oct 23, 2018 at 03:51:20PM +0530, Suganath Prabu wrote: > * If EEDPTagMode field in manufacturing page11 is set, > unset it. This is needed to fix a hardware bug > in SAS3/SAS2 cards, So, skipping EEDPTagMode changes > in Manufacturing page11 for SAS35 controllers. > > * Fix driver modifying NVRAM/persistent data in > Manufacturing page11 along with current copy. Driver should > change only current copy of Manufacturing page11. These *look* like two separate changes that should be in separate patches. Also, fix your subject line so "git log --oneline drivers/scsi/mpt3sas" looks nice This subject line is missing a space in "mpt3sas:Fix" Bjorn