Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <20181025232517.ywnw54qibemosjws@picard> <154083512089.98144.9141070901932719147@swboyd.mtv.corp.google.com>
 <CAHp75VfnN5tF1Z9+CDDhKFNG5QfCRcGOZeAkpf-5BfCEx16gvg@mail.gmail.com>
 <CAHp75VctdBE-GM60udJawBCXdmoOqZn4N=kFWz5GLHzjPG2iQQ@mail.gmail.com>
 <20181029190819.2ivlx73n6y6sx4vk@picard> <ffc4bcc9-62c3-8940-85d6-d0fd01f3a1b8@linux.intel.com>
 <c8fb730a-c160-41b4-dad0-8ed8594e5687@redhat.com> <20181030143836.feo7zcxiestylxoo@picard>
 <d21fe935-5732-7f8c-2c26-3fc3969b4c1c@redhat.com>
In-Reply-To: <d21fe935-5732-7f8c-2c26-3fc3969b4c1c@redhat.com>
From:   Andy Shevchenko <andy.shevchenko@gmail.com>
Date:   Tue, 30 Oct 2018 17:03:05 +0200
Message-ID: <CAHp75Ve8FjHLYkq1uXhen40DDj8DJa42vXXs83qDimigcH-=DA@mail.gmail.com>
Subject: Re: Regression found (Stop-marking-clocks-as-CLK_IS_CRITICAL)
To:     Hans de Goede <hdegoede@redhat.com>
Cc:     duffydack73@gmail.com,
        Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>,
        Stephen Boyd <sboyd@kernel.org>,
        Michael Turquette <mturquette@baylibre.com>,
        linux-clk <linux-clk@vger.kernel.org>,
        Stable <stable@vger.kernel.org>,
        Johannes Stezenbach <js@sig21.net>,
        Carlo Caione <carlo@endlessm.com>,
        Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        mogens-jensen@protonmail.com
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Tue, Oct 30, 2018 at 4:48 PM Hans de Goede <hdegoede@redhat.com> wrote:
> On 30-10-18 15:38, Dean Wallace wrote:

> > Excellent work Hans.  Compiled 4.19 with
> > 0001-ASoC-intel-cht_bsw_max98090_ti-Use-pmc_plt_clk_0-ins.patch, sound
> > works as before.
> >
> > for i in /sys/kernel/debug/clk/pmc_plt_clk_?; do echo -n "$i: "; cat $i/clk_flags; echo; done
> > /sys/kernel/debug/clk/pmc_plt_clk_0:
> > /sys/kernel/debug/clk/pmc_plt_clk_1:
> > /sys/kernel/debug/clk/pmc_plt_clk_2:
> > /sys/kernel/debug/clk/pmc_plt_clk_3:
> > /sys/kernel/debug/clk/pmc_plt_clk_4:
> > /sys/kernel/debug/clk/pmc_plt_clk_5:
>
> Ok, so as I expected the Swanky is using pmc_plt_clk_0
> as mclk instead of pmc_plt_clk_3. Now the question
> becomes is this true for all the designs using the
> max98090 codec?

> 1) Unconditionally use pmc_plt_clk_0 as mclk (as my test patch does)
> in the cht_bsw_max98090_ti.c machine driver

I don't know the details, but the main question here indeed do we ever
had a working example of that machine with CLK #3 in use?

P.S. I would go your first proposal until the opposite will be proved.

-- 
With Best Regards,
Andy Shevchenko