Received: by 2002:ac0:98c7:0:0:0:0:0 with SMTP id g7-v6csp4926197imd; Tue, 30 Oct 2018 09:21:53 -0700 (PDT) X-Google-Smtp-Source: AJdET5dGmaX5nbK0Yh8CZvzvDmsI9+W1zXQqGxoDJLpM3Qqktjo/Oa25TTjMvNstSfb9nrp6tzb9 X-Received: by 2002:a62:a93:: with SMTP id 19-v6mr3545657pfk.121.1540916513142; Tue, 30 Oct 2018 09:21:53 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1540916513; cv=none; d=google.com; s=arc-20160816; b=XYqv8VhPmqQoH7qxpQW8GOEn0a7IKUE0AuUa/uTArG3vvgMwqeLFG7xr8AMp0E/U/p J3+KZ0aHEczMeDzqwfyYwewAiniz7KD2ekswWXLTzItI9fmk95JWaA6dJG720Ex5slTF FAj2ptEV5AM3TCSPFJyToIYlby0f6/lv7pnfEHLbnccE2mJfA/MCtPVoUGxH5d4pQAX8 gT17mqa3wN12tKjSLMiMPKZxJe5AlKGidNzZHsBz9H7VNmQQ//FhndLMAhVRKsqr4lRi +j4Ho/4MyoqMP9PuGLs6HoUs6xGlWurMTbRoGW6JfAU2LBHDHIfC2j1XvIJwjC+wofnZ 8Thw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=+nw3wWqfVi125r2Ty0SrKAS4AMq86yi6J+OvF4otjbg=; b=wJHOEgwla7pigT3M8Zer1Ro726JDgiYCn7eMUO7G54ZdSD9gPZgeOUhMw9b/ytskth w3lvos1X4fvkpANhuE3lYfngCDfhs6JaOvWr+Km5Q8SIlO4kt/0R57vrwkNY9qlLd7wX /wbYCRhvr8UKopy8ImWkxLa8NxYnluS//bZNBggqkK2nKRwKDJhJaTXSeDtiULU3MBEi wgvlt95rgIc1QkX0bKHUzqhtHso4Q/Tq5rixBdeqnTWdpEQogP/wLQogaee2Sk3Ri9DM Xm87lbHTyFpXT37t9Ddkm7xR1ZGSI4FJuT1CrWY6Aac7aeTHyQOi+b8cz/FfkjyqAa5+ nTvw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=RpZa2rLV; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id w126-v6si15244918pfw.257.2018.10.30.09.21.33; Tue, 30 Oct 2018 09:21:53 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=RpZa2rLV; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727520AbeJaBJp (ORCPT + 99 others); Tue, 30 Oct 2018 21:09:45 -0400 Received: from mail-wm1-f66.google.com ([209.85.128.66]:55565 "EHLO mail-wm1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726693AbeJaBJp (ORCPT ); Tue, 30 Oct 2018 21:09:45 -0400 Received: by mail-wm1-f66.google.com with SMTP id s10-v6so12359203wmc.5; Tue, 30 Oct 2018 09:15:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=+nw3wWqfVi125r2Ty0SrKAS4AMq86yi6J+OvF4otjbg=; b=RpZa2rLVcpWgpxOs9ZKzfv9YYXJ5UvaY+xre8invEJxeK5w9tLrruNmIF8wjnNAQsX /mzaB4WuMQtj21keC9CNlHk2UK+nvSH9TXgq/vuGWs2Sg5pl/P3Ri2aNUoBXDVc2ezGi Mp2IyDrZBwV/ozOnDymFrZDcnGtPu2hvRC4AyN/y60fyKEHM7AUV0qT70F8QhU6B5R5v WzW9+qQcwXRVDqMryzQ31SUj+ReWhZRE7NWfIpd5oVWNVQLLFFKSt/2TEvW8JnsTz5Kb YXaNXSVq0Pv/0AN+D7FV19wxXjbIikAC+gKgT6czDjoc6re8OZZzXmfmODktd+Z2V+EZ /JLQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=+nw3wWqfVi125r2Ty0SrKAS4AMq86yi6J+OvF4otjbg=; b=KWd27m1upZ66UanS0SHhks2fzQYmz7aXhQ0W//rZWEVKaz9MzzJUyQpVv1qlzHBUHN WfM9iTld+vUcm5bGDnKxmP/r9qG7+iWf7rQoJc6Y3j5tmRtCXrz8tH+PAF+d77eaG1V/ tE2PqTY7qLw0hqNmlj11g6GvDA0bcp0BZPwsqAgTUsaJ6UMhciy81Wcwvl51XcTbz4+F KbPrWM8jpDzC5TKYtz36kGFR29QfSvxhSHfK6F9GSo7cQBsz6l11NFws+leqBU+PlJ1X GEsojvO/lHHqheeR2STAe1EccRPgSsSCuv0Cy7hnDdyUuWdQVIyQknCJIeod8tIw+3ng UmLg== X-Gm-Message-State: AGRZ1gLmIltsrfHRVvJKb28OYVsqtfxcoH1zTOvswGfOEZs/+obvaUYn ZFQ7YbNntTAc0QDxI7HDXMc= X-Received: by 2002:a1c:6c0f:: with SMTP id h15-v6mr2199643wmc.123.1540916136424; Tue, 30 Oct 2018 09:15:36 -0700 (PDT) Received: from picard ([194.207.103.1]) by smtp.gmail.com with ESMTPSA id e7-v6sm25153360wra.37.2018.10.30.09.15.35 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 30 Oct 2018 09:15:35 -0700 (PDT) Date: Tue, 30 Oct 2018 16:15:34 +0000 From: Dean Wallace To: Hans de Goede Cc: Pierre-Louis Bossart , Andy Shevchenko , Stephen Boyd , Michael Turquette , linux-clk , Stable , Johannes Stezenbach , Carlo Caione , Andy Shevchenko , Linux Kernel Mailing List , Mogens Jensen Subject: Re: Regression found (Stop-marking-clocks-as-CLK_IS_CRITICAL) Message-ID: <20181030161534.wk5cf7nxbwhp2far@picard> References: <154083512089.98144.9141070901932719147@swboyd.mtv.corp.google.com> <20181029190819.2ivlx73n6y6sx4vk@picard> <20181030143836.feo7zcxiestylxoo@picard> <2d429c87-24c5-4075-683e-b0d12c3eb1c2@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: X-Info: Keep It Simple, Stupid. X-Operating-System: Linux, kernel 4.19.0-arch1-1-max98090 X-Message-Flag: WARNING!! Outlook sucks User-Agent: Every email client sucks, this one just sucks less. Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 30-10-18, Hans de Goede wrote: > Hi, > > On 30-10-18 16:46, Hans de Goede wrote: > > Hi, > > > > On 30-10-18 16:04, Pierre-Louis Bossart wrote: > > > In addition I am not aware of any baytrail device using plt_clk_0, > > > so moving a common machine driver such a cht_bsw_max98090_ti to use > > > plt_clk0 only would break other devices (e.g. Rambi/Orco). Asking > > > for both clocks to be on might work though, > > > > Ok, so we need to have a DMI based quirk for the Swanky and maybe also > > the clapper to use plt_clk_0 there. Asking for 2 clks if we only need > > one does not seem like a good plan. > > Dean, Mogens, > > To write a proper patch for this I'm going to need DMI strings > from your devices. > > Can you please run (as normal user): > > grep . /sys/class/dmi/id/* 2> /dev/null > > And reply with the output of this command? Here's mine, for a coreboot uefi based swanky. https://ptpb.pw/~swanky-dmi-log -- Dean