Received: by 2002:ac0:98c7:0:0:0:0:0 with SMTP id g7-v6csp5189028imd; Tue, 30 Oct 2018 13:24:13 -0700 (PDT) X-Google-Smtp-Source: AJdET5fnAeR0VtorIhls9khY3/C3e9rZxCOXoGtQ7moCvBnc0DAlUJEgc5SotQnDV+MflJdvIiv5 X-Received: by 2002:a17:902:b093:: with SMTP id p19-v6mr162743plr.277.1540931053819; Tue, 30 Oct 2018 13:24:13 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1540931053; cv=none; d=google.com; s=arc-20160816; b=bJCYQWH1mq5at0kufEfUvCTNmZqFVt4+VrRp1L/aQ8dY4BB/KOx60mqV0ikW6qwauk G9Q8IWl5ZE3Txs3f1zxpbhSlSMsxNmSjpNh7Iis4S5wsM3dN83Ua1wyUzVbTeCTUrQyh ht3vjMWAuZHDW+m9BS9O2ssoRFEU0o+ldipRceGKYwlptSVfpdsUzK7LyKV5bKeSh/uL RGe4Z1ytnk3i0YApFLGw3JTzlW1Y3PoD+uogcW5e/PFKpYWwuwgHrLOoBdej6/SqYD75 o1jOd/CIBXdiuwbD2UWdNYX0O7qcmj8ySfHB7fkupsBxWxUFb+ruThANieDomobjvE+V TcYA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:user-agent:references :message-id:in-reply-to:subject:cc:to:from:date; bh=AY6G6nzEIKs9+wCBWMYyNwe+kZz/f+/SBC7E81AvjuA=; b=ZUeSoWmceNS7xw9Hj55iQj/Dy+DxlXjYPlWv4uILyoNA6pRvM9y0H9LukI7C0BJoBK kPawrWyZqWaWdTE0VGQX1HieeGhZhi6Sotv2QvLrrTAHKKG32g8WeLkBVY7yC+ii71g6 yTOIe5TFMyiy4m6RzaiKT6v7ZpYPQIzQqGlWZpcP4z3kgKKl0hBKoqacuIUJwDN0uiok 18etK3K+Q6IpYzz6WcqHHFH3VadWXPU/zqTy5g2We99y9AbJkMedsAUuSHPJgOylneY4 eYzvKnBR4fhd4SLYaQWcwdBga5ht4p6KTMQ/RySrfJliTxWVmoDgYu19vghepnG+FoYN Rq5w== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 16-v6si25925759pgp.175.2018.10.30.13.23.58; Tue, 30 Oct 2018 13:24:13 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727784AbeJaErt (ORCPT + 99 others); Wed, 31 Oct 2018 00:47:49 -0400 Received: from mga07.intel.com ([134.134.136.100]:12605 "EHLO mga07.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726017AbeJaErt (ORCPT ); Wed, 31 Oct 2018 00:47:49 -0400 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga105.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 30 Oct 2018 12:52:56 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.54,445,1534834800"; d="scan'208";a="103883078" Received: from anumodth-mobl.gar.corp.intel.com ([10.249.254.57]) by fmsmga001.fm.intel.com with ESMTP; 30 Oct 2018 12:52:48 -0700 Date: Tue, 30 Oct 2018 21:52:45 +0200 (EET) From: Jarkko Sakkinen X-X-Sender: jsakkine@jsakkine-mobl1 To: Roberto Sassu cc: jarkko.sakkinen@linux.intel.com, zohar@linux.ibm.com, linux-integrity@vger.kernel.org, linux-security-module@vger.kernel.org, linux-kernel@vger.kernel.org, silviu.vlasceanu@huawei.com Subject: Re: [PATCH v3 5/5] tpm: ensure that output of PCR read contains the correct digest size In-Reply-To: <20181030154711.2782-6-roberto.sassu@huawei.com> Message-ID: References: <20181030154711.2782-1-roberto.sassu@huawei.com> <20181030154711.2782-6-roberto.sassu@huawei.com> User-Agent: Alpine 2.21 (DEB 202 2017-01-01) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 30 Oct 2018, Roberto Sassu wrote: > This patch ensures that the digest size returned by the TPM during a PCR > read matches the size of the algorithm passed as argument to > tpm2_pcr_read(). The check is performed after information about the PCR > banks has been retrieved. > > Signed-off-by: Roberto Sassu What is the scenarion when this can happen (should be explained in the commit message)? /Jarkko