Received: by 2002:ac0:98c7:0:0:0:0:0 with SMTP id g7-v6csp5190494imd; Tue, 30 Oct 2018 13:25:57 -0700 (PDT) X-Google-Smtp-Source: AJdET5fmsdlQXY9tUxRsc2k8+ZkEdRV0w8P3fPV+Ds0XrrFLgjFc74HEtBcR5sOARfr7NB5YeKZw X-Received: by 2002:a17:902:2e81:: with SMTP id r1-v6mr211058plb.212.1540931157362; Tue, 30 Oct 2018 13:25:57 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1540931157; cv=none; d=google.com; s=arc-20160816; b=cPXb8M01hqNajwI6xHLNhAG8Fa/BflgIT1gjz29cz+qntkEoLbmq9+o2EQvmMqpIxf orrfOfl0kXw1jravMjAQYWz9anWdQkMX3LxHhJ5sDEWc0r2cKdb2ZjqpOI0pDY+wyX4i w0ZB/kT/Akbq5u4DqlOGt2AwzyMMakGs1buNV6m3sDJfOoo5pdIycFCYIZ5UFETENAsS igbCcUEzU/rH9XNySHiLWLZvsUz0S6mOuD/vq8yvEqG3xixWqgPMHCQ5Dz4S+i2kqFc3 dF7+LqRGb2hnEcAkzNaXp2BDZph7S0D33GyF0KZ+VHSDyRA3vKMnqUsQHz5jdZLi44sw ieOQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature; bh=YHlA1Gy9bikOKYy8gzOAw1wz0+eQluWCb2m298a9UsA=; b=M4haMupf/Q/IyZuB3gHFzF40rrbEXgcwbkiGssCEnzgAkQwd96fjzB6J6kAvgngvJ/ VrZrpu/LPT8crtLKUfvU6XKX5+0oiy9uabQK4BY1rEkRFDXXJgg40m3QQlQMqBmax+oA 0oEUdUOgPc4XthgqA6GN7lnD4Z5PPsAYt413nWJj0ZA1MdqjDNmxfCXUOTXwapM4pEIu BWDs6azWNG2Yk955pLI/381ncoqb7YiAEAwJZqYezRjJdVzBxzgL1vWOkd7fHv+Jzqb/ qRcln8Lq1nGvY0hIEMd1pzL56vF+MmWl0z7Vdt01ImaXtWqVphsy+tuczO0isGk5SQS0 1l1w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linux-foundation.org header.s=google header.b=d72Byb2Q; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id t64-v6si7142721pfd.58.2018.10.30.13.25.41; Tue, 30 Oct 2018 13:25:57 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@linux-foundation.org header.s=google header.b=d72Byb2Q; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727843AbeJaFCM (ORCPT + 99 others); Wed, 31 Oct 2018 01:02:12 -0400 Received: from mail-lf1-f66.google.com ([209.85.167.66]:42972 "EHLO mail-lf1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726863AbeJaFCM (ORCPT ); Wed, 31 Oct 2018 01:02:12 -0400 Received: by mail-lf1-f66.google.com with SMTP id q6-v6so9883783lfh.9 for ; Tue, 30 Oct 2018 13:07:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux-foundation.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=YHlA1Gy9bikOKYy8gzOAw1wz0+eQluWCb2m298a9UsA=; b=d72Byb2QHgPqTgAXvhHNvfoMjdDL+qRXq8PyQsTUBX+BSh1aY+dF33CZzrYg8JSsSn /HZRfN5/n7oQ/Dg4G9zq20D61EXR1n9qOKtknZY+dxm6Wn7pHGrgtl2aohmKZF9AiuVE Fmy7UPs8GF+4fssy3XS+X2ixM640fNszugEqM= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=YHlA1Gy9bikOKYy8gzOAw1wz0+eQluWCb2m298a9UsA=; b=SgVA3xU+KAPhESHhYWGCHZP61EQR+idvV3aIRdUVdRwdMK1BLVPf2P24ImFQMvTGwH Jsh9byCD2lE3iGTGfV2X3R2htkxyHPyLboe9qT9vEqPeD/4QhF+KivX9zUfFlU/Q1DdV jni7MiBZoo/iYB2/gvs3y1yM6jUd627mWwuIoMp0Txf11t3fi9nqv9Hl9fF68tS3lxND FiIV0I9sJzwsBSVUdF3cjZcr02Vhi5Kou5k9xbimlrpxszH30nQYHnfYNQjDDhjGwLsi Q//RTdd8qigwWvP48802KONTI2x1rY0EuNNbLuZMTG7m/6wtEXekQFawSqgTne1qg/oq x8fQ== X-Gm-Message-State: AGRZ1gJsp1CP9ioLSePs5E/3cSu9VNYGg2Z8cVvR0ss5F+CEeSG/DvBM 1LCBd8mTWF4XBJ4Ne1A+6uC6PeQO7McwIw== X-Received: by 2002:a19:6719:: with SMTP id b25mr88728lfc.38.1540930035468; Tue, 30 Oct 2018 13:07:15 -0700 (PDT) Received: from mail-lf1-f43.google.com (mail-lf1-f43.google.com. [209.85.167.43]) by smtp.gmail.com with ESMTPSA id f76sm678670lfl.74.2018.10.30.13.07.14 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 30 Oct 2018 13:07:14 -0700 (PDT) Received: by mail-lf1-f43.google.com with SMTP id h192so9917251lfg.3 for ; Tue, 30 Oct 2018 13:07:14 -0700 (PDT) X-Received: by 2002:a19:7019:: with SMTP id h25-v6mr68821lfc.147.1540930033935; Tue, 30 Oct 2018 13:07:13 -0700 (PDT) MIME-Version: 1.0 References: <20181030191710.GA23042@fieldses.org> In-Reply-To: From: Linus Torvalds Date: Tue, 30 Oct 2018 13:06:58 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [GIT PULL] nfsd changes for 4.20 To: bfields@fieldses.org Cc: linux-nfs@vger.kernel.org, Linux Kernel Mailing List , jlayton@redhat.com Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Oct 30, 2018 at 12:55 PM Linus Torvalds wrote: > > Pulled, Oh, I take that back. Semantic conflict with locking name change (recv_lock -> queue_lock) and new code in net/sunrpc/xprtrdma/svc_rdma_backchannel.c exposed by my build test. And looking around, it was reported in linux-next, but you didn't mention it, which kind of makes the whole reporting pointless. Guys, what is the point of linux-next if you then don't *react* to it? The correct reaction is to say during the merge window that "hey, linux-next showed this issue", just so that I know about it and it doesn't take me by surprise. Yes, my normal build tests caught it, and I've fixed up my merge, but this isn't how things are supposed to work. Linus