Received: by 2002:ac0:98c7:0:0:0:0:0 with SMTP id g7-v6csp5544480imd; Tue, 30 Oct 2018 20:41:51 -0700 (PDT) X-Google-Smtp-Source: AJdET5eFKUygeXwkNAsjomVRljPys7pSwCLS8NDgNJGkWeS5zZBcif92UCNvBMkaTkd01DTd8KfG X-Received: by 2002:a62:4dc4:: with SMTP id a187-v6mr1582536pfb.92.1540957311548; Tue, 30 Oct 2018 20:41:51 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1540957311; cv=none; d=google.com; s=arc-20160816; b=DVWcLza8VAQKJNfp04RCnJeaZ5hs5C+LgF8XJJn6knsPxo0W0glkgIcZVpmDZ/8ldc ///7zoYZ5fezGKPFle6FpuWGdIsYkqPPvgR+AzYL6uEspOIOVkZ4mPGl9ijJdnxYumMB IoAS8ovIcxQ6a0Wn8NvXVKIx4dAFDMjdM8MbJjYvYWH6efCNoMGbRnMubOBmLQnxMvyr otpgQVXAzYl2TARtj00ASA2Tad/UdHzSGqwPzv1HslI1uElFGyYN2wcQm4zUWjsrqg9f 6cU00tlUSzEhw5Vy4ydl7nTBM8bx6VpMMlSbe7zgHxCh9vrxtvkitH7t+2AIcuVp+/d9 2ZZw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject; bh=iiBbxm5P5HD67twVihLMFvZBpTLu8gFzePvGp4Obgzc=; b=hua5JSIINyY8vX2aPomhdmX8I3PoazW5u9Pcgsd/5Y+gjX9j9FUXUC2yTuxtWowOiM BUXgp10kSTcM51fro/9PfympsNgUz5OckpN9ztn+tTlSSNEchiSlx30yQ/3jtFfxq5qz C/R0VrXHx9nwec/EXEp+jUqxOHJHwCMlvJZ51gT+u4pXhQmmZuHTUi3JHeqtfJRuptAY JEC1+OS4bAlvB0JpO2sLq0ipKw+Dk2ghZLf45qaK9k3GcushvEde94fccuoUsmw4Kswa v5dy9aBhq/IgmcVZHQJw5iPj2yfX5xn1c3cgCCFcblBRvLrmyggbSkQq2+SsXmFxtfsT QBRg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=virtuozzo.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id n61-v6si24254036plb.169.2018.10.30.20.41.37; Tue, 30 Oct 2018 20:41:51 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=virtuozzo.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729136AbeJaMfi (ORCPT + 99 others); Wed, 31 Oct 2018 08:35:38 -0400 Received: from relay.sw.ru ([185.231.240.75]:55596 "EHLO relay.sw.ru" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728578AbeJaMfi (ORCPT ); Wed, 31 Oct 2018 08:35:38 -0400 Received: from [172.16.24.21] by relay.sw.ru with esmtp (Exim 4.90_1) (envelope-from ) id 1gHhLl-0004IV-L6; Wed, 31 Oct 2018 06:39:21 +0300 Subject: Re: [PATCH v2 11/11] ext4: access to uninitialized bh fields in ext4_xattr_set_handle() To: Andreas Dilger Cc: linux-ext4@vger.kernel.org, Theodore Ts'o , Andreas Dilger , linux-kernel@vger.kernel.org References: <48BA929C-9BF7-4092-BDD3-BECB64AF0599@dilger.ca> From: Vasily Averin Message-ID: <0db97e14-c87d-9507-4c87-875835b64212@virtuozzo.com> Date: Wed, 31 Oct 2018 06:39:20 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <48BA929C-9BF7-4092-BDD3-BECB64AF0599@dilger.ca> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10/31/2018 04:30 AM, Andreas Dilger wrote: > Could you please explain your statement below that on-stack > initialization does not zero unspecified fields?  According  > to documents I found, for example: > > https://gcc.gnu.org/onlinedocs/gcc/Designated-Inits.html > > they *are* initialized to zero.  I did not know it, I re-checked it in generated assembler code and found that you are right and I was wrong. Please drop this patch, should I resend of rest of this patch set once again? Thank you, Vasily Averin