Received: by 2002:ac0:98c7:0:0:0:0:0 with SMTP id g7-v6csp6067885imd; Wed, 31 Oct 2018 06:25:43 -0700 (PDT) X-Google-Smtp-Source: AJdET5dlG1Icb8iSoNwmdX3lIi6SL9V2wS4kack3VLgGOVRM0HqK2qbanKkASoSv4qnut5m1Dy9H X-Received: by 2002:a62:1fdb:: with SMTP id l88-v6mr3403720pfj.213.1540992343708; Wed, 31 Oct 2018 06:25:43 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1540992343; cv=none; d=google.com; s=arc-20160816; b=aazCNPpM9fnvdBp+hja+of3nn8+bSe5DPxylbwvkNVLrv4M2HmtETrekTekQOVu7oM 4OE+uupvyQ4IDUc2Jy5VS4W0x6+RIqtP7fvMCL88zq6+re8Xh6afygybpJicRRkMfepx gUL0ecvJ3jVf+A09yfCjADGdtwlC8LLmAXqAMVnDVISvaO29JageVCW1gRYcolMoPVt7 SU6TvPb5Hpi/1Nw10D+LvIa6bE60fVT1674CUSB/g8E3GAQ6HZBma5Dn0AWwhUPwgYNX SCXr7dAOcmcmDYiy6YKzG94aN7Yszebdnd8zD4+Jl0v/Sz80D74ktEZcPTQqear184WA lcEQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from:dkim-signature; bh=ejdq2iAILhXuBUzBm5b1+5FdxwkTFXYLi2UC8hcWNRQ=; b=GVZerCec5jZsPoAnBgit3OpYsRQxRndGCXqJ/kojvp5FbQs+KXUHt2n+cGtnsbwdXC aqXd/yrAJAOSa8qxoDNr7BkdFuPdBtdUzfbVx7o5kEoOm6VPxUqq3uByDYP8ga3/MCto uNaHswj82pX/s4wTxZDHMf7mx4gZSjVS756NliXYdBCyBBDXQjmeKOXoe1/lE70BH6MY LQD56MNgRfWJWSriq0RUAKAu7//YLaraQBJdbq6nNJ/pT2yQhFwsYvFRD6fEfTrbjwP/ VpZkHPnfnA0elPoePv6ZaqlVhuxDBY6UUzk6P+zV/a4/IeJDYcll7NLbEnaIr3sGpi24 Rcwg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@broadcom.com header.s=google header.b=Kf8+c6Q1; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=broadcom.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id z188-v6si15577355pgb.75.2018.10.31.06.25.29; Wed, 31 Oct 2018 06:25:43 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@broadcom.com header.s=google header.b=Kf8+c6Q1; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=broadcom.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729430AbeJaWWv (ORCPT + 99 others); Wed, 31 Oct 2018 18:22:51 -0400 Received: from mail-wm1-f65.google.com ([209.85.128.65]:40025 "EHLO mail-wm1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729271AbeJaWWv (ORCPT ); Wed, 31 Oct 2018 18:22:51 -0400 Received: by mail-wm1-f65.google.com with SMTP id b203-v6so14557973wme.5 for ; Wed, 31 Oct 2018 06:24:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=ejdq2iAILhXuBUzBm5b1+5FdxwkTFXYLi2UC8hcWNRQ=; b=Kf8+c6Q102OvZvnTwjj50CdT9IfffMtzPGIY+oCBNs2T1u3rtVgD4lq0peAaDuCQpH P+Mvx8ob870aZX2EJaWLvFjmB9mKWCVRPnd28fVb1yDXiS+Uc/PP1WSKsxIGhotmrn/e d6kwOY6WBHxlc02dhOSMPvZtEFUNOZBSLyadk= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=ejdq2iAILhXuBUzBm5b1+5FdxwkTFXYLi2UC8hcWNRQ=; b=MuEjFp3ddV5F07IAuqPj+fG4TpLCNSRHoxkZVBSk9Kck36J5NLw4wuwSOtb2HxHkkG 7L31EYhJAUHmatAOYz5Y15T/DdzXLjNBbppOqKd1in4h5fRC0bKuVKxEoH+t3A9yl/BY UpP42Wn/aVI5/XbSNQ01xKLzs24uIwmQwpyFjNjD99E9agDitz3OEmGPhBqWhsUlEcGc aYumpFIPT6wJjEYOvl8QezZgSvSJ0xDKjF60Jzm+KASwbtO6TYDHzGhwLDhTPr/LECbb DDhsrNscxp8ut4r3RpVo5zbMyTap2f47C2F+cYueXHhjO3GCn7Hv121cAmZpFwAhvto4 4DBw== X-Gm-Message-State: AGRZ1gIpSSLHdh4YZjolstpatp+ow9BktYsLBDrhGTlZYT1h53AHPhDX Gg2Ti92i8hqFNWNro92/WTT+UQ== X-Received: by 2002:a1c:4601:: with SMTP id t1-v6mr2336964wma.102.1540992288664; Wed, 31 Oct 2018 06:24:48 -0700 (PDT) Received: from dhcp-10-123-74-106.dhcp.broadcom.net ([192.19.234.250]) by smtp.gmail.com with ESMTPSA id r16-v6sm25202614wrv.21.2018.10.31.06.24.45 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 31 Oct 2018 06:24:48 -0700 (PDT) From: Suganath Prabu To: linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Sathya.Prakash@broadcom.com, sreekanth.reddy@broadcom.com, Suganath Prabu Subject: [PATCH v7 7/8] mpt3sas: Fix driver modifying persistent data in Manufacturing page11 Date: Wed, 31 Oct 2018 18:53:38 +0530 Message-Id: <1540992219-20291-8-git-send-email-suganath-prabu.subramani@broadcom.com> X-Mailer: git-send-email 1.8.3.1 In-Reply-To: <1540992219-20291-1-git-send-email-suganath-prabu.subramani@broadcom.com> References: <1540992219-20291-1-git-send-email-suganath-prabu.subramani@broadcom.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Currently driver is modifying both current & NVRAM/persistent data in Manufacturing page11. Driver should change only current copy of Manufacturing page11. It should not modify the persistent data. So removed the section of code where driver is modifying the persistent data of Manufacturing page11. Signed-off-by: Suganath Prabu --- drivers/scsi/mpt3sas/mpt3sas_config.c | 4 ---- 1 file changed, 4 deletions(-) diff --git a/drivers/scsi/mpt3sas/mpt3sas_config.c b/drivers/scsi/mpt3sas/mpt3sas_config.c index 257b66f..8516713 100644 --- a/drivers/scsi/mpt3sas/mpt3sas_config.c +++ b/drivers/scsi/mpt3sas/mpt3sas_config.c @@ -658,10 +658,6 @@ mpt3sas_config_set_manufacturing_pg11(struct MPT3SAS_ADAPTER *ioc, r = _config_request(ioc, &mpi_request, mpi_reply, MPT3_CONFIG_PAGE_DEFAULT_TIMEOUT, config_page, sizeof(*config_page)); - mpi_request.Action = MPI2_CONFIG_ACTION_PAGE_WRITE_NVRAM; - r = _config_request(ioc, &mpi_request, mpi_reply, - MPT3_CONFIG_PAGE_DEFAULT_TIMEOUT, config_page, - sizeof(*config_page)); out: return r; } -- 1.8.3.1