Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <1540957223-30984-1-git-send-email-harini.katakam@xilinx.com>
 <1540957223-30984-2-git-send-email-harini.katakam@xilinx.com> <20181031134810.GD20889@lunn.ch>
In-Reply-To: <20181031134810.GD20889@lunn.ch>
From:   Harini Katakam <harinik@xilinx.com>
Date:   Wed, 31 Oct 2018 19:20:50 +0530
Message-ID: <CAFcVECKDhQHcHyHoyP-xWRkAt0sVAhy2mB8yweZGsGwTnBsyVA@mail.gmail.com>
Subject: Re: [PATCH 1/4] net: macb: Check MDIO state before read/write and use timeouts
To:     Andrew Lunn <andrew@lunn.ch>
Cc:     Harini Katakam <harini.katakam@xilinx.com>,
        Nicolas Ferre <nicolas.ferre@microchip.com>,
        David Miller <davem@davemloft.net>,
        Claudiu Beznea <claudiu.beznea@microchip.com>,
        netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
        Michal Simek <michal.simek@xilinx.com>,
        Shubhrajyoti Datta <shubhrajyoti.datta@xilinx.com>,
        sai.pavan.boddu@xilinx.com
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Hi Andrew,

>
> Hi Harini
>
> Could you make use of readx_poll_timeout(). You will need to add a
> helper for the read of the register, since readx_poll_timeout() only
> allows one parameter.
>
> Otherwise, this looks O.K.

Sure, will do. Thanks.

Regards,
Harini