Received: by 2002:ac0:98c7:0:0:0:0:0 with SMTP id g7-v6csp6132773imd; Wed, 31 Oct 2018 07:18:40 -0700 (PDT) X-Google-Smtp-Source: AJdET5egCjFbkk1LosJzz/0MBqfPQmhSMH5TQp4po9guiKnImZT6pLMqf+NE78iazb5dSTLMPIvV X-Received: by 2002:a62:9c4a:: with SMTP id f71-v6mr3708785pfe.135.1540995520418; Wed, 31 Oct 2018 07:18:40 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1540995520; cv=none; d=google.com; s=arc-20160816; b=ez1mqpOaXR+G1Eldc3ETTXovoPpOyT3qV29in11YWMSgl0dZ8oJWmSfMTALiBbx2U+ c+u03eJInr9tyanSda0zouQQ9HCSZUXrDw1oRP72Da2JYWA4gzs3jSv1LfzFWBOLKKlP UyhWj/UfescDE3BrcZzM/PkEgocKghAGAC4f8ayK7Wn4m+HelUVedpUe8djwEVD1/g7I sbpnT8k5s+ZcS2Op1FRFVUaOqKHyIgnZVHD68mayCnoDxpgVgGVRnssF+1YaDNa3nRgZ UJjvK/By5CLm/eweQSzBf+UyFFHjntBBL0YN9oeSAl1o7QAXnra1oveHxIncRp3QUK9A Bpag== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:to:subject:dkim-signature; bh=5UpullBLVcT/e6vPfRg78NsTkfPPe4/w8oFXT4PilmA=; b=PeljXmJPCCI0GcpDudOt2A7/0nEOJ+1kIchSjxV5lzEK4eioUEorbkhrcnQzWN7YqJ QQzFgEjApa21qwatrmkV+yXU0RrfOLRDqnQ2JnDpSleMsy5SB8sf0Z/oAN7kngz6UVg7 Dt8XmRyZYN4xxsuVMQQcrjI2E+1Uy9l2bxkwPVZINfhFOKvzXSa2Hd9Kw3+GuVioAVuq dr23hyXpvIGgu/vsRKdNB2vXlt8KUshm0kiW5rk5wU+kEz/vM6XX4oZYrpoSKb7cMtYQ pgTzdNMr91m9FJ7M9Nx1aeAvMmfg2yaMVTmMRLWL5fXrSGi+xeQtDVz85PwF4qortJoN GlDw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel-dk.20150623.gappssmtp.com header.s=20150623 header.b=lba8EueQ; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id c12-v6si27228633pgl.551.2018.10.31.07.18.25; Wed, 31 Oct 2018 07:18:40 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel-dk.20150623.gappssmtp.com header.s=20150623 header.b=lba8EueQ; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729508AbeJaXP7 (ORCPT + 99 others); Wed, 31 Oct 2018 19:15:59 -0400 Received: from mail-io1-f50.google.com ([209.85.166.50]:36345 "EHLO mail-io1-f50.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729463AbeJaXP7 (ORCPT ); Wed, 31 Oct 2018 19:15:59 -0400 Received: by mail-io1-f50.google.com with SMTP id o19-v6so9779666iod.3 for ; Wed, 31 Oct 2018 07:17:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20150623.gappssmtp.com; s=20150623; h=subject:to:references:from:message-id:date:user-agent:mime-version :in-reply-to:content-language:content-transfer-encoding; bh=5UpullBLVcT/e6vPfRg78NsTkfPPe4/w8oFXT4PilmA=; b=lba8EueQnK78efeF9qGMYV5J0rVPNt9iIROLA3aUpB3IUhSvB2xP484EJ2C7DcmFvi JUCfZFf2eSvDA3vmOac0O0RqL90JKbfH1spJmJw2CptZ44bb6BFL4EA6445gGiBz0vy7 0lPOOTjq7LaqGCIgiywH8E3xIDdQrTnA4qxPUHxo9yefL1kdISSWeEOh/GVmnUQUaaOf r8gTQXoshJTRJl9TnykIsFpYzM13Mil81zgutsGIWn8eMyY/bQc6J+ETzVw/Wr4/7aA3 SVFEFwPriKRSQ4PNiMKj2yHrYdFFRsG001kxc81wR5zA49mdfqn1TC3gT3s666KR/p92 BdZg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=5UpullBLVcT/e6vPfRg78NsTkfPPe4/w8oFXT4PilmA=; b=KI2fM2QMguclzF+ZabkkmAyAHtoDgXlDRfpDI8PV0eQ1PsrIvYL4iJmW21I+KyIEjE nRRVSc4UxPEDCWGMhq67fdeJ859FNPLWVe60g9aPjnLwpl3z/Ed/BbLpiyohKmgZ03Hc 6YBWyHuCh/OQdtCTNXI8LqC6Luri8OdabSDm2eQ/oHr5MZ0p0U1x6P6J5QwWINpEtDAS H6UcwEMAy+NFQ60RHITQGZ7QCPLQRnawj4GHc/PatiBUFm6M7A9ovM2bFSEM6QupsZA6 STA561cIsRSyusBkjIu+l4A/l8J39CaGIvKzr6R9wgh7zlQhmgnJFa2bkQgBkrijYMhS Iz/A== X-Gm-Message-State: AGRZ1gJ6pNRCNnqTqmh23toqBDjvUEYfeETwFK3Xmkmm8d1u7HbrQt9t LLy/QO7ec5MP14Rc3671uCZOcA7xwtk= X-Received: by 2002:a6b:590d:: with SMTP id n13-v6mr2248148iob.176.1540995465911; Wed, 31 Oct 2018 07:17:45 -0700 (PDT) Received: from [192.168.1.56] ([216.160.245.98]) by smtp.gmail.com with ESMTPSA id k133-v6sm9955191itb.16.2018.10.31.07.17.44 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 31 Oct 2018 07:17:44 -0700 (PDT) Subject: Re: [PATCH 02/16] blk-mq: abstract out queue map To: Sagi Grimberg , linux-block@vger.kernel.org, linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org References: <20181030183252.17857-1-axboe@kernel.dk> <20181030183252.17857-3-axboe@kernel.dk> <725b4d35-2390-58d9-4041-0bac6de6cd77@grimberg.me> From: Jens Axboe Message-ID: Date: Wed, 31 Oct 2018 08:17:43 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.2.1 MIME-Version: 1.0 In-Reply-To: <725b4d35-2390-58d9-4041-0bac6de6cd77@grimberg.me> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10/30/18 6:31 PM, Sagi Grimberg wrote: > >> @@ -41,12 +41,12 @@ int blk_mq_rdma_map_queues(struct blk_mq_tag_set *set, >> goto fallback; >> >> for_each_cpu(cpu, mask) >> - set->mq_map[cpu] = queue; >> + set->map[0].mq_map[cpu] = queue; > > Any reason not to change the signature like the other mappers? No particular reason, outside of not wanting to touch more than I had to. -- Jens Axboe