Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S265174AbUAEQu4 (ORCPT ); Mon, 5 Jan 2004 11:50:56 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S265172AbUAEQuw (ORCPT ); Mon, 5 Jan 2004 11:50:52 -0500 Received: from ns.virtualhost.dk ([195.184.98.160]:43752 "EHLO virtualhost.dk") by vger.kernel.org with ESMTP id S265168AbUAEQtI (ORCPT ); Mon, 5 Jan 2004 11:49:08 -0500 Date: Mon, 5 Jan 2004 17:49:02 +0100 From: Jens Axboe To: Bartlomiej Zolnierkiewicz Cc: Christophe Saout , linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: Possibly wrong BIO usage in ide_multwrite Message-ID: <20040105164902.GA3483@suse.de> References: <1072977507.4170.14.camel@leto.cs.pocnet.net> <200401032302.32914.bzolnier@elka.pw.edu.pl> <20040105040337.GB6393@leto.cs.pocnet.net> <200401051747.45039.bzolnier@elka.pw.edu.pl> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200401051747.45039.bzolnier@elka.pw.edu.pl> Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 841 Lines: 22 On Mon, Jan 05 2004, Bartlomiej Zolnierkiewicz wrote: > > calling end_request with a null sector count, ide_end_request will then > > take hard_nr_sectors which will end the whole request even if only one > > bio was finished, huh? Am I missing something here? > > No, it is used mainly to fail requests. > > This hack should be later removed with care > (there is some strange comment about locking). IIRC, it's due to it not always being safe to inspect rq state outside of ide_lock. So that makes 0 a magic value that just means 'end the first chunk' for ide_end_request(). -- Jens Axboe - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/