Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <20181030205334.148162-1-dianders@chromium.org> <20181031115910.5bqgtnzf2zujnp5b@holly.lan>
In-Reply-To: <20181031115910.5bqgtnzf2zujnp5b@holly.lan>
From:   Doug Anderson <dianders@chromium.org>
Date:   Wed, 31 Oct 2018 08:05:54 -0700
Message-ID: <CAD=FV=W+NScZ8KCcBhULwmx3VMx0uUro=jKm7og9-OsRKmNdmA@mail.gmail.com>
Subject: Re: [PATCH] kdb: Fix btc (backtrace on each cpu) crash
To:     Daniel Thompson <daniel.thompson@linaro.org>
Cc:     Jason Wessel <jason.wessel@windriver.com>, me@tobin.cc,
        Joe Perches <joe@perches.com>, stable@vger.kernel.org,
        kgdb-bugreport@lists.sourceforge.net,
        LKML <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Hi,

On Wed, Oct 31, 2018 at 4:59 AM Daniel Thompson
<daniel.thompson@linaro.org> wrote:
>
> On Tue, Oct 30, 2018 at 01:53:34PM -0700, Douglas Anderson wrote:
> > Typing 'btc' on kdb doing all sorts of fail.  Sometimes it would
> > crash, sometimes display nothing, and sometimes hang.
> >
> > Bisect tracked this down to the commit ad67b74d2469 ("printk: hash
> > addresses printed with %p"), suggesting an obvious fix.  The pointer
> > used internally in kdb shouldn't be hashed, so switch it to %px.
> >
> > Fixes: ad67b74d2469 ("printk: hash addresses printed with %p")
> > Cc: stable@vger.kernel.org
> > Signed-off-by: Douglas Anderson <dianders@chromium.org>
>
> I think we've already got a fix for this:
> https://git.kernel.org/pub/scm/linux/kernel/git/jwessel/kgdb.git/commit/?h=kgdb-next&id=a0ca72c2d1ac83d0853a23ffde8f3624648b1ee8

Ah ha.  Nice!  Sorry for not noticing this.  The newest I tested was 4.19.

-Doug