Received: by 2002:ac0:98c7:0:0:0:0:0 with SMTP id g7-v6csp6298892imd; Wed, 31 Oct 2018 09:36:57 -0700 (PDT) X-Google-Smtp-Source: AJdET5cWhZzaxZHhOVr079zzC9bu9vFPmimOKOyZcFx1ls+chs7khnyXC3NBgEok0akZRZllWiS2 X-Received: by 2002:a65:6295:: with SMTP id f21-v6mr3861873pgv.167.1541003817041; Wed, 31 Oct 2018 09:36:57 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1541003817; cv=none; d=google.com; s=arc-20160816; b=OmEk5ROc7KSToqBR/caaapxX8SZ1St6F/DOIYXUy+XrhtxwAXJgUNy7JnoR4japT6x lSsqanwbs8jPOnF+M5SwPCQyrBGGjk3UlmcJG0uWI5nc8PuMECCI1AYsD+X3yQivK7gg Ktw+kUBUL3JP/D4755OBv9rlGumPeWQ6q6wMu32+hPefw2BYxxp/HFC9WLAW5GHsC/aZ nvefYHLBT7acAW82CGkMDJcYdPxaWWKo9kI/JffSycswKnt6DcNHOu72N64l8pYhK4eJ +G6gfDv/CEnRt/jITZuMIsa9hMB/zfKnBMoK5E/yUL8pL1Kf4C0SeUe0tk02KnZK9oRz JYpg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=vK4d+tLOZ8mMFC2i8i4qwTHyNmO4RB7dk90JPoy7Jd4=; b=MRV0IdHETTylLuNLP0OEj+Whd4qiBJgLUu6UC6tYL+XqXIIwNMjOdzmUlcGYMThqLr vGtFXpQwnTm/MaCAjnMy4bnpcYIfjEwwmGam2sYodwd0n7XrxmGAQs6VkfZf08Fw6VjU vQnp3CKD2HvSJHZfAswQP2s0/C0EOcKWQ/i9bxMjxq+buv9MhMhtcygDYIwGZBHF5L5W o3nLS2koYJSIfvJBQ+UzQ1jS06lkPE3fdIoCA10QQxP6EzNRfeg17IQyw0N/kx5z4/Gk 503K8wnj8yT0wvgExN9bd0yinoa2fQkq0yJznJJc8qAliEH3M0mSkdXDO+LnC8BEwMZp NZ5g== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id x18-v6si27260798plr.146.2018.10.31.09.36.40; Wed, 31 Oct 2018 09:36:57 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729832AbeKABew (ORCPT + 99 others); Wed, 31 Oct 2018 21:34:52 -0400 Received: from zeniv.linux.org.uk ([195.92.253.2]:33498 "EHLO ZenIV.linux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729341AbeKABew (ORCPT ); Wed, 31 Oct 2018 21:34:52 -0400 Received: from viro by ZenIV.linux.org.uk with local (Exim 4.90_1 #2 (Red Hat Linux)) id 1gHtTN-0002mR-Rg; Wed, 31 Oct 2018 16:36:01 +0000 Date: Wed, 31 Oct 2018 16:36:01 +0000 From: Al Viro To: "Eric W. Biederman" Cc: Linus Torvalds , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [git pull] mount API series Message-ID: <20181031163601.GR32577@ZenIV.linux.org.uk> References: <20181031053355.GQ32577@ZenIV.linux.org.uk> <87a7mut9cm.fsf@xmission.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87a7mut9cm.fsf@xmission.com> User-Agent: Mutt/1.9.1 (2017-09-22) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Oct 31, 2018 at 10:38:17AM -0500, Eric W. Biederman wrote: > A couple of bugs that I can see quickly. Several of which I have > previously reported: > > - There is an easily triggered NULL pointer deference with open_tree > and mount propagation. What the hell? If the fixes that went in do not handle something, especially if you have testcases, where the fuck have you been and where _are_ those testcases, while we are at it? Eric, this is bloody ridiculous - "I have an easily triggered NULL pointer dereference in..., here it is" is hard to miscommunicate. Sure, any such needs to be fixed. For crying out loud, that thing has not been hidden - it sat in -next, it's been reposted several times... I'm glad that you can see bugs. How about _showing_ them? Because I don't see anything that would prevent this reply of yours from being posted pretty much verbatim cycle after cycle, no matter what gets done.