Received: by 2002:ac0:98c7:0:0:0:0:0 with SMTP id g7-v6csp6471251imd; Wed, 31 Oct 2018 12:12:59 -0700 (PDT) X-Google-Smtp-Source: AJdET5fTjfdAVV1lel5/A384R9plSZ2xVaJSxc1wUssBeCw3qfdFa2fBwxvS/XaQDGmWp/rHQmp2 X-Received: by 2002:a65:41c2:: with SMTP id b2mr2550333pgq.67.1541013179084; Wed, 31 Oct 2018 12:12:59 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1541013179; cv=none; d=google.com; s=arc-20160816; b=qOIBE/Sg6xBwHjUyl/Vwpy5n7TXlXCwWDUQsKPdVESax6KbLn5ZuROsTYXZ5wUzID5 1v4iqLZAbE91ZofpDBEeyO6o1+OmGecLnFLqhvRmka6HAPwtCEyCCPMreFkU02Qgw6GP 3GhvK+MOnFyRkgNrkVD6iX76MyKQRDY2OSithjfPzwvwyQdXFQJLmMOykFIYTX6+G/e4 WTattkuZSeerT8rWulg5R0uzgiE7GFuPNtj812+eNfVdNE3r5OcjRcTx0eOWn5bJuWMq owyQdss1B/HoVdMXg4NdkWTpcnDDqS2X6M9UOmrwi9LArl5SxgybnYbYYLTMbo5u0HeS 8f1A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:mime-version:user-agent:date:message-id:cc:to :subject:from; bh=J/51l0xLt0dtezDOL1i7TCM6eELy86gAcKfDY0uA+/8=; b=RacSmz+ydgsunOgepbJSt2wvBXpyFRnwx7dDtmQgRnbkIQXJEkhsIa9hrfDXIBvQCr Cw/P7z+Jlr/ICDgCVm1QVZq10AEqmPFCIAX6u4r7hpkhaXSiPxM4ems3Vn1Q0LP12i17 l3zPn6+NrY8n6C+aQ2t9f7HR22mZQb1fIn7cUNFM9mwMyF8zCQ5m9NLGh1hoCl4cWQL+ 1ZJdc2+s53cO1AycBfP1b7at1Ph2dwV6IWsYWpo3eP9Pp5UV1s/r/U7GNQk57hLAtguJ 21qN49CoEQNZ/EUMbjV4g/2eNmRrPHfGts6iHN5c7/ZYPCmycCGKt0Q8e8o6NTwVW+xu Hc7A== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=virtuozzo.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id f66-v6si28407151pfc.35.2018.10.31.12.12.43; Wed, 31 Oct 2018 12:12:59 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=virtuozzo.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726292AbeKAELi (ORCPT + 99 others); Thu, 1 Nov 2018 00:11:38 -0400 Received: from relay.sw.ru ([185.231.240.75]:47164 "EHLO relay.sw.ru" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725731AbeKAELi (ORCPT ); Thu, 1 Nov 2018 00:11:38 -0400 Received: from [172.16.24.21] by relay.sw.ru with esmtp (Exim 4.90_1) (envelope-from ) id 1gHvuW-0006Jx-QD; Wed, 31 Oct 2018 22:12:12 +0300 From: Vasily Averin Subject: [PATCH 0/7] ext4 long-lived issues, part two To: linux-ext4@vger.kernel.org, Theodore Ts'o Cc: Andreas Dilger , linux-kernel@vger.kernel.org Message-ID: Date: Wed, 31 Oct 2018 22:12:12 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org I've found one more batch of long-lived ext4 issues, most of them are lost brelse + two leaks on rollback in ext4_fill_super. Oldest one was found in 2.6.23, last one -- in 4.18. Vasily Averin (7): ext4: lost brelse in __ext4_read_dirblock() ext4: possible sbi->s_group_desc leak in ext4_fill_super ext4: lost release of s_journal_flag_rwsem on rollback in ext4_fill_super ext4: lost brelse in ext4_xattr_get_block() ext4: bs.bh cleanup before re-using in ext4_xattr_block_find() ext4: lost brelse in ext4_xattr_move_to_block() ext4: lost brelse in ext4_expand_extra_isize_ea() fs/ext4/namei.c | 1 + fs/ext4/super.c | 4 +++- fs/ext4/xattr.c | 15 ++++++++++++--- 3 files changed, 16 insertions(+), 4 deletions(-) -- 2.17.1