Received: by 2002:ac0:98c7:0:0:0:0:0 with SMTP id g7-v6csp6472876imd; Wed, 31 Oct 2018 12:14:21 -0700 (PDT) X-Google-Smtp-Source: AJdET5ctJuYuSO6CKGPRVD5xHtAkzH8Rid4v5bLn9x8vU9ii3UoxmwBhCj9X5IOO/dAZgzJ4VRB5 X-Received: by 2002:a63:bd51:: with SMTP id d17mr4378719pgp.443.1541013261322; Wed, 31 Oct 2018 12:14:21 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1541013261; cv=none; d=google.com; s=arc-20160816; b=Aj0hAiKJL8liUZMsCPuuvuSExFMQzyPx9sqZs5uRE/EmEzk3mHpFJG24NbpLMX2Fcx EpwL5KCFnRONXv+RqiVywdyyB4XENKJJSe4BU6aiMgFjZDF0UTZIVOuC/Cz1w3xaU40T Km4YF2ZmJj6ULwpE1XaLCBHBXu2lr/DtP8ddHdUsTcIgFCn7oIqY8ZE3DSlYraEL2hwG A01ouoJdkd5Ogee3iU/mOoBTJpO8D8TFsQCzce/y4he74SJAmvsfPSCTv4IOhcyVNQEv 8q24cyOI3gpREdIBBAAyNP2RR+9fcRVQQXXkRQ+wfl0sqIceDXM2SNHGxwRt6f/Cjpm1 UuMQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:references:cc:to:subject:from; bh=mr1CgXvyIpczg3ECnv5OiN6t4AZnt+312IcghO9/UTs=; b=md2Rku6RKO7rVMRJP19j+qz3/ujRSgvTFArneRiQSWqzk1/l9qUMBCKVOVxjx1VoMk 8zCBCd3LhdLuCIX3mo4M1FR7QqknPziJICUvYHSH4XGaZvMz1rv7WWd8APatwTIz6xbW mPET3uKQ5d2FZioniEmdjzxZfpXjFy0YkL5AKn7peWhIaPwIORHpQfKLUgTy+BvzwbIl cEYhrluwAYHaGSUDzq2qkSjhYOJbYLhjk0Vjh45xjn7hpcqrEDf9hJZPocO8HjbrzIV5 udSrukoELhxb17gLv67o8F9Wnu4DXle0Mjah/AaZvK6eo5cloUkip+5nVNJ76CYKdUFL ZYFQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=virtuozzo.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id r25-v6si28267730pgl.146.2018.10.31.12.14.06; Wed, 31 Oct 2018 12:14:21 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=virtuozzo.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730387AbeKAEM2 (ORCPT + 99 others); Thu, 1 Nov 2018 00:12:28 -0400 Received: from relay.sw.ru ([185.231.240.75]:47220 "EHLO relay.sw.ru" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725731AbeKAEM1 (ORCPT ); Thu, 1 Nov 2018 00:12:27 -0400 Received: from [172.16.24.21] by relay.sw.ru with esmtp (Exim 4.90_1) (envelope-from ) id 1gHvvJ-0006Km-2V; Wed, 31 Oct 2018 22:13:01 +0300 From: Vasily Averin Subject: [PATCH 6/7] ext4: lost brelse in ext4_xattr_move_to_block() To: linux-ext4@vger.kernel.org, Theodore Ts'o Cc: Andreas Dilger , linux-kernel@vger.kernel.org, Jan Kara , Kalpak Shah References: Message-ID: <76da5ae3-274d-efa4-58bb-6cd280763a37@virtuozzo.com> Date: Wed, 31 Oct 2018 22:13:00 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Fixes 3f2571c1f91f ("ext4: factor out xattr moving") cc: Jan Kara however issue was present in original ext4_expand_extra_isize_ea() Fixes 6dd4ee7cab7e ("ext4: Expand extra_inodes space per ...") # 2.6.23 cc: Kalpak Shah Signed-off-by: Vasily Averin --- fs/ext4/xattr.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/fs/ext4/xattr.c b/fs/ext4/xattr.c index 07b9a335c8eb..5c9bc0d85cc0 100644 --- a/fs/ext4/xattr.c +++ b/fs/ext4/xattr.c @@ -2617,6 +2617,8 @@ static int ext4_xattr_move_to_block(handle_t *handle, struct inode *inode, kfree(buffer); if (is) brelse(is->iloc.bh); + if (bs) + brelse(bs->bh); kfree(is); kfree(bs); -- 2.17.1