Received: by 2002:ac0:98c7:0:0:0:0:0 with SMTP id g7-v6csp6487749imd; Wed, 31 Oct 2018 12:29:32 -0700 (PDT) X-Google-Smtp-Source: AJdET5cgqf0pmacgGAwKJNT9VIIJifgkecd4WADZWo4KTivRIo+HwSCiTFyqIXl/a+7qAQRpZQyT X-Received: by 2002:a62:564e:: with SMTP id k75-v6mr4687181pfb.33.1541014172458; Wed, 31 Oct 2018 12:29:32 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1541014172; cv=none; d=google.com; s=arc-20160816; b=sZpZvh/o1EKuTGn40JK3D1LNCT4cQbOoqWuC5vzr56FJJuucQJT5iIfKsbMFZZbTtW 6P+vmrb+g1mEwOSvmJmEDbzEbmcuaAiwtcQpKP8+9w4ph1AlObGky/UkzM732m04JWeW Pl5TPB3Gj/ln6wD3O6DfwN9JZJGr5R5joyIj5mb/LoXLERUXsYGtBZNmuarAv37pClob J/sUE8rV4fCdd+jZb5TbHAVOz/Bugg34XDHUfC5sMeHIepqYSC/Y5AH2caCIMcsOwriJ 3PyJCbZtQAdRJwvgYDrGoL/HcAYRMswsgwSxCbLu6K2g2uHeIKx+Wj0pUpjjAaEjDmM+ N2+Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:references:cc:to:subject:from; bh=k0upiqQYfgFwGh8KxDBT9AGpdhpfyGZ07W8+Ebeo0ko=; b=oH4TlenqcPQUrVtkB7URTlAmLnej1DTguUj/A1FBzVWgtZPwmJ01E5P5VAOPUzLk5G eUJWMkeKsGWLArpimbHkfbHPnO17ZkBHARdIhwVonHj6n+lsphHhg61Z+lj+UB7pvXQr +JwheMNQ7rVNEPZDhGppc8UqivY1USVBJhQEroBmGVsDFMyD6QhKQk7xF6EE98nGJ0as WxW+gCQ1+1TGflwkuzcqOk5+bCiCA8PugwXnsKcb+aSM/Oc+M/5DuClu1XRrFYSs2R0s q4I82uOes65JeklUHWEfH1kkCwJcgPZtENiTrnJd33CkIyMxDLWgbqnkLyFoZzDqdqMm YC1w== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=virtuozzo.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id b3-v6si16335157pld.305.2018.10.31.12.29.17; Wed, 31 Oct 2018 12:29:32 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=virtuozzo.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726350AbeKAELn (ORCPT + 99 others); Thu, 1 Nov 2018 00:11:43 -0400 Received: from relay.sw.ru ([185.231.240.75]:47174 "EHLO relay.sw.ru" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725731AbeKAELm (ORCPT ); Thu, 1 Nov 2018 00:11:42 -0400 Received: from [172.16.24.21] by relay.sw.ru with esmtp (Exim 4.90_1) (envelope-from ) id 1gHvud-0006KA-4r; Wed, 31 Oct 2018 22:12:19 +0300 From: Vasily Averin Subject: [PATCH 1/7] ext4: lost brelse in __ext4_read_dirblock() To: linux-ext4@vger.kernel.org, Theodore Ts'o Cc: Andreas Dilger , linux-kernel@vger.kernel.org References: Message-ID: <60f19df8-1e65-99a0-cb6b-696d1b530fd4@virtuozzo.com> Date: Wed, 31 Oct 2018 22:12:18 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Fixes dc6982ff4db1 ("ext4: refactor code to read directory blocks ...") # 3.9 Signed-off-by: Vasily Averin --- fs/ext4/namei.c | 1 + 1 file changed, 1 insertion(+) diff --git a/fs/ext4/namei.c b/fs/ext4/namei.c index d388cce72db2..1a21e59ede72 100644 --- a/fs/ext4/namei.c +++ b/fs/ext4/namei.c @@ -111,6 +111,7 @@ static struct buffer_head *__ext4_read_dirblock(struct inode *inode, if (!bh) { ext4_error_inode(inode, func, line, block, "Directory hole found"); + brelse(bh); return ERR_PTR(-EFSCORRUPTED); } dirent = (struct ext4_dir_entry *) bh->b_data; -- 2.17.1