Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
In-Reply-To: <7505.1541011140@warthog.procyon.org.uk>
References: <20181031053355.GQ32577@ZenIV.linux.org.uk> <87a7mut9cm.fsf@xmission.com>
 <7505.1541011140@warthog.procyon.org.uk>
From:   Miklos Szeredi <miklos@szeredi.hu>
Date:   Wed, 31 Oct 2018 21:49:59 +0100
Message-ID: <CAJfpegtJwkrFECtLBzm8WrYhhDjbQSAuB4ZsoDzbKh6T7UZJUA@mail.gmail.com>
Subject: Re: [git pull] mount API series
To:     David Howells <dhowells@redhat.com>
Cc:     "Eric W. Biederman" <ebiederm@xmission.com>,
        Al Viro <viro@zeniv.linux.org.uk>,
        Linus Torvalds <torvalds@linux-foundation.org>,
        linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Wed, Oct 31, 2018 at 7:39 PM, David Howells <dhowells@redhat.com> wrote:
>> My objections fundamentally is that I can find real problems when I look
>> at the code.

I think the big risk with such a change is not that there are bugs,
but that we get the API wrong, and have to keep supporting a broken
API forever.

Were any of your objections of that type?

There's the argument about sharing of super blocks doing weird things,
but we can't get rid of that one due to having to support the old
mount(2) API forever anyway.  That's not a new burden, and the new API
allows fixing this incrementally by adding better models later.

Thanks,
Miklos