From: Bartlomiej Zolnierkiewicz <B.Zolnierkiewicz@elka.pw.edu.pl>
To: Jens Axboe <axboe@suse.de>
Subject: Re: Possibly wrong BIO usage in ide_multwrite
Date: Mon, 5 Jan 2004 19:27:40 +0100
User-Agent: KMail/1.5.4
Cc: Christophe Saout <christophe@saout.de>, linux-ide@vger.kernel.org,
       linux-kernel@vger.kernel.org
References: <1072977507.4170.14.camel@leto.cs.pocnet.net> <200401051813.30625.bzolnier@elka.pw.edu.pl> <20040105181627.GB3483@suse.de>
In-Reply-To: <20040105181627.GB3483@suse.de>
MIME-Version: 1.0
Content-Type: text/plain;
  charset="iso-8859-2"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
Message-Id: <200401051927.40360.bzolnier@elka.pw.edu.pl>
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1180
Lines: 28

On Monday 05 of January 2004 19:16, Jens Axboe wrote:
> On Mon, Jan 05 2004, Bartlomiej Zolnierkiewicz wrote:
> > On Monday 05 of January 2004 17:49, Jens Axboe wrote:
> > > On Mon, Jan 05 2004, Bartlomiej Zolnierkiewicz wrote:
> > > > > calling end_request with a null sector count, ide_end_request will
> > > > > then take hard_nr_sectors which will end the whole request even if
> > > > > only one bio was finished, huh? Am I missing something here?
> > > >
> > > > No, it is used mainly to fail requests.
> > > >
> > > > This hack should be later removed with care
> > > > (there is some strange comment about locking).
> > >
> > > IIRC, it's due to it not always being safe to inspect rq state outside
> > > of ide_lock. So that makes 0 a magic value that just means 'end the
> > > first chunk' for ide_end_request().
> >
> > Why/when it is not safe to do?
>
> You would need to read hwgroup->rq.

Okay I see it, non IRQ context.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/