Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S265218AbUAETdx (ORCPT ); Mon, 5 Jan 2004 14:33:53 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S265264AbUAETdo (ORCPT ); Mon, 5 Jan 2004 14:33:44 -0500 Received: from pizda.ninka.net ([216.101.162.242]:19341 "EHLO pizda.ninka.net") by vger.kernel.org with ESMTP id S265218AbUAETdg (ORCPT ); Mon, 5 Jan 2004 14:33:36 -0500 Date: Mon, 5 Jan 2004 11:28:00 -0800 From: "David S. Miller" To: Berkley Shands Cc: gibbs@scsiguy.com, berkley@cs.wustl.edu, linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org Subject: Re: [BUG] x86_64 pci_map_sg modifies sg list - fails multiple map/unmaps Message-Id: <20040105112800.7a9f240b.davem@redhat.com> In-Reply-To: <200401051929.i05JTsM0000014248@mudpuddle.cs.wustl.edu> References: <200401051929.i05JTsM0000014248@mudpuddle.cs.wustl.edu> X-Mailer: Sylpheed version 0.9.7 (GTK+ 1.2.6; sparc-unknown-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 880 Lines: 18 On Mon, 5 Jan 2004 13:29:54 -0600 (CST) Berkley Shands wrote: > The pci layer is modifying the sg list, and then placing a zero > in the length field. pci-gart.c at line 453 (2.6.0 sources) checks this length field > after a retry, sees that it is zero, and bughalts. Oh that's a bug. It is allowed to modify the dma_length field but not the physical length field. I imagine x86_64 is doing this so that there need not be a seperate dma_length field in the scatter_gather struct defined for that platform, and that's too bad it will definitely need such a seperate field if it wants to implement coalescing. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/