Received: by 2002:ac0:98c7:0:0:0:0:0 with SMTP id g7-v6csp163810imd; Wed, 31 Oct 2018 16:35:54 -0700 (PDT) X-Google-Smtp-Source: AJdET5dj7mzWcimc/kfLoI8fpWwvsU+UCJOZxPQeUQ51lymoPtpS0jYJZLCDHrwVOOfbypO4eTIq X-Received: by 2002:a63:7541:: with SMTP id f1-v6mr4663795pgn.231.1541028954430; Wed, 31 Oct 2018 16:35:54 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1541028954; cv=none; d=google.com; s=arc-20160816; b=Ap9CVUaxhRur8LigCPXGcv5cpvuJviNBS5R9kgIskdi/ksGTG1qTgd4ZDSn8TFpyDL 8dsjfr/ZASuCIl1BC3R+baMItZJmuUMnTkV79SnGWtNVjSciL8ekjBvblj2fNdjbKB+9 E52rieXALJgW8O6ebx66jHrJcBtWIxu6UN4Qk+wD66kP9DX85xsa6sFM3mOZWSDsMTJX iOL+CcFz97P+WiY92WfxDXngiYPrVSEcMuOeCKieA+pYJGCf4kYr2zjEzv0VhsNJKYm+ ima0R7MflD9KSNS35EJHw/c3tXDBX18qXOFO7eQ82SUOs/UsSCNnsHm8J/xAJe/zxQSo mEfA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=9g4R9m4grUCYD72eMvyV+JdllOHsPzLPFYNmnAJwO2A=; b=mklilhEbtkTnnfb5cQzujf3llhToD58zB/QNHBMUfCG8WiEJPaQ95U0K0tdZRXn6eU ocQifJgUCXJhQk5mQK2R8fV30JGdfqeEZaHsQ8AM0ev7M0d+XnA/DCAnf7B4+YOTur80 nsS2WBb8bl9rcmKq5HViRcwJpYD7/rAuKRlUNEKwSqaZ7+cf+zFCMGlbxOXLXQek4QfM vfOLAyHoVDTiRr0x8dFgTzVPccsABJDe/047mDKmjuiJ+4as6DxpEYvbrlTL3jsL7+zB cnWMtUexNK0ONA2BGJyRZaSWzKkURsTrJAv1bbJ9YhmgaoMRtTHVVRoG4y1I96qicV2e nYRA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id l185si5008701pgd.253.2018.10.31.16.35.39; Wed, 31 Oct 2018 16:35:54 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730570AbeKAIf0 (ORCPT + 99 others); Thu, 1 Nov 2018 04:35:26 -0400 Received: from sauhun.de ([88.99.104.3]:59796 "EHLO pokefinder.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728699AbeKAIf0 (ORCPT ); Thu, 1 Nov 2018 04:35:26 -0400 Received: from localhost (unknown [87.114.85.207]) by pokefinder.org (Postfix) with ESMTPSA id 529682E35EA; Thu, 1 Nov 2018 00:35:04 +0100 (CET) Date: Wed, 31 Oct 2018 23:35:02 +0000 From: Wolfram Sang To: Charles Keepax Cc: linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org, patches@opensource.cirrus.com Subject: Re: [PATCH 2/2] i2c: Clear client->irq in i2c_device_remove Message-ID: <20181031233502.GB8321@kunai> References: <20181019085958.32694-1-ckeepax@opensource.cirrus.com> <20181019085958.32694-2-ckeepax@opensource.cirrus.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="dTy3Mrz/UPE2dbVg" Content-Disposition: inline In-Reply-To: <20181019085958.32694-2-ckeepax@opensource.cirrus.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --dTy3Mrz/UPE2dbVg Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Oct 19, 2018 at 09:59:58AM +0100, Charles Keepax wrote: > The IRQ will be mapped in i2c_device_probe only if client->irq is zero and > i2c_device_remove does not clear this. When rebinding an I2C device, > whos IRQ provider has also been rebound this means that an IRQ mapping > will never be created, causing the I2C device to fail to acquire its > IRQ. Fix this issue by clearing client->irq in i2c_device_remove, > forcing i2c_device_probe to lookup the mapping again. >=20 > Signed-off-by: Charles Keepax Applied to for-current, thanks! --dTy3Mrz/UPE2dbVg Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEOZGx6rniZ1Gk92RdFA3kzBSgKbYFAlvaPCYACgkQFA3kzBSg KbagKA/9FcmeFpRbTCBZSnQ0ei127fILessOcNaMqJhi386/lKyF87/Wo7MbuYnw 5lbtxe16L40Mt0tvdbT/Q1K5FUJ6OerTGz3NwJeiQJhAkQxCbHdc+w9bByMbwyqi 18f4q/PgBqpiUsIwu5HzXJLfZyVdhX5/m1uvG+Gi+pwIRk7yx5bbuZpx5pIDUtN1 2Bi6+pmQhDMbHIGQTo3fw6MHax/FX0aQ70WJ64o/2g2Apa+IynbksZvjkdq5Cc8W /GikRRPSN7Ngx0xJUyQ2YP1Ct/LX4de0uLre9eWqnATvZTrRk/puXQWvAm3ywz8X JVNbwFdYFVxUCk12W4d/5uWw37R6Ah+diav8W7KsPzoNhCvmRFkSq5ROpyVXzlZ4 rhFsa5uoNqN6x5lUMpkfWFeNHaS3NPTWnCcLw8fb7ZBe0vyc5riWGb0Kr9hU86fC UKHhgh1eEynn/WIOLNKQMADn4qjc9H9wQg2IqhXO8z/CIp8b6c2fT1QE3mnKH7VA QWcX2jdYzEDIOK67sy4HlSMJ0gm+RXPdq9JLHN0nvrpoLDSbrqx75P0jbptOXUrE rB6dPJV6/lMCAwCq6ZcHU5wkTQGoPmXrLq8Mu3VDMigac3DyRKNM10/81/QMcRO7 6xdGQX9BKDe7bJFDIgQ5+BPoewa2luHv7qpnlA2WZrk76CFFmwk= =Aof/ -----END PGP SIGNATURE----- --dTy3Mrz/UPE2dbVg--