Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Wed, 31 Oct 2018 18:36:28 -0700 (PDT)
Message-Id: <20181031.183628.2259691990575006225.davem@davemloft.net>
To:     niklas.cassel@linaro.org
Cc:     peppe.cavallaro@st.com, alexandre.torgue@st.com,
        joabreu@synopsys.com, mcoquelin.stm32@gmail.com, vkoul@kernel.org,
        netdev@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com,
        linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] net: stmmac: Fix stmmac_mdio_reset() when building
 stmmac as modules
From:   David Miller <davem@davemloft.net>
In-Reply-To: <20181031150810.16665-1-niklas.cassel@linaro.org>
References: <20181031150810.16665-1-niklas.cassel@linaro.org>
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

From: Niklas Cassel <niklas.cassel@linaro.org>
Date: Wed, 31 Oct 2018 16:08:10 +0100

> When building stmmac, it is only possible to select CONFIG_DWMAC_GENERIC,
> or any of the glue drivers, when CONFIG_STMMAC_PLATFORM is set.
> The only exception is CONFIG_STMMAC_PCI.
> 
> When calling of_mdiobus_register(), it will call our ->reset()
> callback, which is set to stmmac_mdio_reset().
> 
> Most of the code in stmmac_mdio_reset() is protected by a
> "#if defined(CONFIG_STMMAC_PLATFORM)", which will evaluate
> to false when CONFIG_STMMAC_PLATFORM=m.
> 
> Because of this, the phy reset gpio will only be pulled when
> stmmac is built as built-in, but not when built as modules.
> 
> Fix this by using "#if IS_ENABLED()" instead of "#if defined()".
> 
> Signed-off-by: Niklas Cassel <niklas.cassel@linaro.org>

Applied and queued up for -stable, thanks.