Received: by 2002:ac0:98c7:0:0:0:0:0 with SMTP id g7-v6csp602784imd; Thu, 1 Nov 2018 02:31:16 -0700 (PDT) X-Google-Smtp-Source: AJdET5cAxsID7WBNL1g+RFJ2Fk8HXh7MmzC5wD1iRh96KG/4/FcuAIFQC6knnJBkpPuRm9QHcUo8 X-Received: by 2002:a62:42dc:: with SMTP id h89-v6mr7263965pfd.0.1541064676154; Thu, 01 Nov 2018 02:31:16 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1541064676; cv=none; d=google.com; s=arc-20160816; b=zPSjB/GkJL0ErT1kKngDAPrdiSPaUOklZQcfh37B2hxBQxYcC0Axg/l7FH5846Q4MG aXlzOq7LDJF0x6iUG5S4N7z57OBhoos9BpHxCTNJEmqJTlgvJrvRaThHjzrWp6RW3S1L ViHm36Z57isATEX2y+FSfmPYyz/6zbeNQWssZgyL3JW6nO2IfO3z7VEqFmIBfjt4HN23 JWnIPhuzE+42EjPN59H+mLIIvp59ZgyPgOiMVTPfHGBAoY9OwBBpU1HismYUZo/ryQg5 w7Fi+p1ty3jNOiJKyhpw0T6PwBvfq118OziuvBHg/bjy8RZXBNIQ1yEaJ4rqDLrJuf3n 6AFw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:to:subject; bh=SpP4Nze770hiaYnhYZI4NL3hZBgr5CuvJhLD7vvpDdk=; b=s6eOf/qOsnDBVKaQ9KItZbe2uzeQSHqee7zEeF9dUPZVfWVYi0/bYn/C9ZiUmDHiHQ rwCFueF+gFR1QGuBakBUxrDQnfZEvTyHZPgooZHOib9oa6FE2NvJL7otUULGrmHfdegP 3cnlhzJfsM85fFXHnRvmPALN0OUPAaXjFDZskpsRcCroWfADLsCgqBpK4boJT4DsSlqz jA8htwpnXCAMadp53DQQTtXr9j1TylrKMHBrVwyGi1XjeZW6/U7IOipyXq+vA0DVHft7 83cV5aOl8Q0VOaY0/yqm1X7TB2IWB/4S40FQ7MLEYXAhWVLyDpyLbYZxA90COxC2joS8 ziKA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 30-v6si13709580pla.56.2018.11.01.02.31.02; Thu, 01 Nov 2018 02:31:16 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727862AbeKAScx (ORCPT + 99 others); Thu, 1 Nov 2018 14:32:53 -0400 Received: from mx2.suse.de ([195.135.220.15]:50360 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726023AbeKAScx (ORCPT ); Thu, 1 Nov 2018 14:32:53 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay1.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id AF08AAF70; Thu, 1 Nov 2018 09:30:40 +0000 (UTC) Subject: Re: [PATCH 11/16] blk-mq: improve plug list sorting To: Jens Axboe , linux-block@vger.kernel.org, linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org References: <20181030183252.17857-1-axboe@kernel.dk> <20181030183252.17857-12-axboe@kernel.dk> From: Hannes Reinecke Message-ID: Date: Thu, 1 Nov 2018 10:30:39 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.2.1 MIME-Version: 1.0 In-Reply-To: <20181030183252.17857-12-axboe@kernel.dk> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10/30/18 7:32 PM, Jens Axboe wrote: > Currently we only look at the software queue, but with support > for multiple maps, we should also look at the hardware queue. > This is important since we'll flush out the request list if > either the software queue or hardware queue don't match. > > This sorts by software queue first, then hardware queue if > that differs. Finally we sort by request location like before. > This minimizes the flush points per plug list. > > Signed-off-by: Jens Axboe > --- > block/blk-mq.c | 17 ++++++++++++----- > 1 file changed, 12 insertions(+), 5 deletions(-) > Reviewed-by: Hannes Reinecke Cheers, Hannes