Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Thu, 1 Nov 2018 11:14:02 +0100 (CET)
From:   Thomas Gleixner <tglx@linutronix.de>
To:     Peng Hao <penghao122@sina.com.cn>
cc:     rkrcmar@redhat.com, pbonzini@redhat.com, x86@kernel.org,
        kvm@vger.kernel.org, linux-kernel@vger.kernel.org,
        Peng Hao <peng.hao2@zte.com.cn>
Subject: Re: [PATCH] kvmclock : convert to SPDX identifiers
In-Reply-To: <1541007211-5041-1-git-send-email-penghao122@sina.com.cn>
Message-ID: <alpine.DEB.2.21.1811011105020.1642@nanos.tec.linutronix.de>
References: <1541007211-5041-1-git-send-email-penghao122@sina.com.cn>
User-Agent: Alpine 2.21 (DEB 202 2017-01-01)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Peng,

On Wed, 31 Oct 2018, Peng Hao wrote:

a few nitpicks upfront. The proper prefix for this is: x86/kvmclock

Most of the time, you can deduce the prefix from running 'git log
path/to/file'.

> This patch updates license to use SPDX-License-Identifier
> instead of verbose license text

git grep 'This patch' Documentation/process

> Signed-off-by: Peng Hao <peng.hao2@zte.com.cn>
> ---
>  arch/x86/kernel/kvmclock.c | 15 +--------------
>  1 files changed, 1 insertions(+), 14 deletions(-)
> 
> diff --git a/arch/x86/kernel/kvmclock.c b/arch/x86/kernel/kvmclock.c
> index 1e67646..0ebd715 100644
> --- a/arch/x86/kernel/kvmclock.c
> +++ b/arch/x86/kernel/kvmclock.c
> @@ -1,19 +1,6 @@
> +// SPDX-License-Identifier: GPL-2.0

But, this is the wrong tag. The verbose text has:

> -    the Free Software Foundation; either version 2 of the License, or
> -    (at your option) any later version.

So what you want here is: GPL-2.0+ or GPL-2.0-or-later

You really need to be very careful when replacing boiler plate text with
SPDX identifiers.

Thanks,

	tglx