Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Thu, 1 Nov 2018 13:17:58 +0100 (CET)
From:   Thomas Gleixner <tglx@linutronix.de>
To:     "Woodhouse, David" <dwmw@amazon.co.uk>
cc:     "mingo@kernel.org" <mingo@kernel.org>,
        "zhenzhong.duan@oracle.com" <zhenzhong.duan@oracle.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "daniel@iogearbox.net" <daniel@iogearbox.net>,
        "peterz@infradead.org" <peterz@infradead.org>,
        "bp@suse.de" <bp@suse.de>,
        "srinivas.eeda@oracle.com" <srinivas.eeda@oracle.com>,
        "konrad.wilk@oracle.com" <konrad.wilk@oracle.com>,
        "michal.lkml@markovi.net" <michal.lkml@markovi.net>,
        "hpa@zytor.com" <hpa@zytor.com>,
        "mingo@redhat.com" <mingo@redhat.com>,
        "yamada.masahiro@socionext.com" <yamada.masahiro@socionext.com>,
        "luto@kernel.org" <luto@kernel.org>
Subject: Re: [PATCH v2 1/2] retpolines: Only enable retpoline support when
 compiler support it
In-Reply-To: <90a9eed724b28d5af57a71694a95b4cd92728ccc.camel@amazon.co.uk>
Message-ID: <alpine.DEB.2.21.1811011317400.1642@nanos.tec.linutronix.de>
References: <991cbe9b-1e31-4b12-b572-91fde5c79699@default>  <20181101095002.GA118944@gmail.com> <90a9eed724b28d5af57a71694a95b4cd92728ccc.camel@amazon.co.uk>
User-Agent: Alpine 2.21 (DEB 202 2017-01-01)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Thu, 1 Nov 2018, Woodhouse, David wrote:
> On Thu, 2018-11-01 at 10:50 +0100, Ingo Molnar wrote:
> > * Zhenzhong Duan <zhenzhong.duan@oracle.com> wrote:
> > 
> > > Since retpoline capable compilers are widely available, make
> > > CONFIG_RETPOLINE hard depend on it.
> > > 
> > > The check of RETPOLINE is changed to CONFIG_RETPOLINE.
> > > 
> > > This change is based on suggestion in https://lkml.org/lkml/2018/9/18/1016
> > > 
> > > Signed-off-by: Zhenzhong Duan <zhenzhong.duan@oracle.com>
> > > Cc: Thomas Gleixner <tglx@linutronix.de>
> > > Cc: Peter Zijlstra <peterz@infradead.org>
> > 
> > Please turn such 'based on suggestions' into proper tags as well, i.e. 
> > something like:
> > 
> >   Suggested-by: David Woodhouse <dwmw2@infradead.org>
> 
> I think the suggestion came from PeterZ; I just acked it.
> 
> Although on furthe reflection, I think I'd prefer a build break if
> retpoline is enabled in the kernel config and the compiler doesn't
> support it. This patch would make it silently fail to be secure.

Agreed.

Thanks,

	tglx