Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH 09/16] blk-mq: cache request hardware queue mapping
To:     Hannes Reinecke <hare@suse.de>, linux-block@vger.kernel.org,
        linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org
References: <20181030183252.17857-1-axboe@kernel.dk>
 <20181030183252.17857-10-axboe@kernel.dk>
 <222351ec-bf5b-526c-33dd-bd2e8ba051fa@suse.de>
From:   Jens Axboe <axboe@kernel.dk>
Message-ID: <5a12d8c2-cb16-168c-f8e2-ffe1649d6554@kernel.dk>
Date:   Thu, 1 Nov 2018 06:22:14 -0600
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101
 Thunderbird/60.2.1
MIME-Version: 1.0
In-Reply-To: <222351ec-bf5b-526c-33dd-bd2e8ba051fa@suse.de>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On 11/1/18 3:27 AM, Hannes Reinecke wrote:
> On 10/30/18 7:32 PM, Jens Axboe wrote:
>> We call blk_mq_map_queue() a lot, at least two times for each
>> request per IO, sometimes more. Since we now have an indirect
>> call as well in that function. cache the mapping so we don't
>> have to re-call blk_mq_map_queue() for the same request
>> multiple times.
>>
>> Signed-off-by: Jens Axboe <axboe@kernel.dk>
>> ---
>>   block/blk-flush.c      | 12 ++++--------
>>   block/blk-mq-debugfs.c |  4 +---
>>   block/blk-mq-sched.c   |  6 ++----
>>   block/blk-mq-tag.c     |  9 +--------
>>   block/blk-mq.c         | 22 +++++++++-------------
>>   block/blk-mq.h         |  5 +----
>>   include/linux/blkdev.h |  1 +
>>   7 files changed, 19 insertions(+), 40 deletions(-)
>>
> Hehe.
> I had been wondering about this since the original mq implementation, 
> but was told not to worry :-)

To be fair, it was just an array index. Now it's got an indirect
call, so it's more expensive.
 > Reviewed-by: Hannes Reinecke <hare@suse.com>

Thanks!

-- 
Jens Axboe