Received: by 2002:ac0:98c7:0:0:0:0:0 with SMTP id g7-v6csp854296imd; Thu, 1 Nov 2018 06:39:30 -0700 (PDT) X-Google-Smtp-Source: AJdET5f9De8rtqWaUB0VutR7hWSQilrrHi9oYwXiR36qtF453k0/Tk0Ozpq4NvEFucVKya5rciNv X-Received: by 2002:a63:86c2:: with SMTP id x185mr6694940pgd.230.1541079570017; Thu, 01 Nov 2018 06:39:30 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1541079569; cv=none; d=google.com; s=arc-20160816; b=jH3cRE7q7vb+aZqGG62+3naIIcg1V7spYmC4NAI64zKmnv/1VZ1gS7DBuqQHLabgMY bG9ZLr5vgZ/ac9O4AUKkule+sUH61EfkpKF4EjO1jDPgU5G5QurHCrUJv/YK4hPwInqR Lxxb1Nkm9rH+FsgVcZadRaYj7Zs1tWuDsBZq/oOl+G9LBg1zTL+uIIy96X0eqJqNWlSN sWjPcWR3Ef3blEgi6LWuQfBuZoHzmCsupfVWxqwt7x6Nb0crylWRlvtG5qjrzVwhI7KR 0OEaPRCRr1GH+6vzalq77oq82h3O4BaFOpFfftMy9weY3JXaeWpnqzxaeubdZ1z+7U1j A3KQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-disposition :content-transfer-encoding:mime-version:robot-unsubscribe:robot-id :git-commit-id:subject:to:references:in-reply-to:reply-to:cc :message-id:from:date; bh=uvtK6b2R2b4rKBZ2VtTjqDmvWAncaEqOEfdTTMLIZ4M=; b=aQmmzVTQn7eflAMTVB6e1H9yOLKSs9GE6ty5bi4gclQHq0V8F1B34p6jotqrDJJx1C pVlgLrIo315JRnoJE4v7/eOucDrqpMkc2WN8NTelIutzTJ9ZKmafUhkicu7HIS//8Dwh ZTCp9MsRkWiIxRMSlpWha18GOoJFphei9AOl62Z/gvF/fKXD0O4xyd9OB4Sv/6cxBAou 4CRB13pLgWRrzRXD3xYufkYKwDyteABguYJy1a8C8mU7PxOUaaITQdMtTkO6laoUyX8X 3ba8YcyTYvNTvxbyVnUKBtVexCTY9Ou2M7d11QnTb4ON+Kjif2bG5aSbyksr+IsfqfpW Ed2g== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id u8-v6si5063007plk.39.2018.11.01.06.39.12; Thu, 01 Nov 2018 06:39:29 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728588AbeKAWkA (ORCPT + 99 others); Thu, 1 Nov 2018 18:40:00 -0400 Received: from terminus.zytor.com ([198.137.202.136]:45515 "EHLO terminus.zytor.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727998AbeKAWkA (ORCPT ); Thu, 1 Nov 2018 18:40:00 -0400 Received: from terminus.zytor.com (localhost [127.0.0.1]) by terminus.zytor.com (8.15.2/8.15.2) with ESMTPS id wA1Dap7g2835722 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO); Thu, 1 Nov 2018 06:36:51 -0700 Received: (from tipbot@localhost) by terminus.zytor.com (8.15.2/8.15.2/Submit) id wA1Daorn2835719; Thu, 1 Nov 2018 06:36:50 -0700 Date: Thu, 1 Nov 2018 06:36:50 -0700 X-Authentication-Warning: terminus.zytor.com: tipbot set sender to tipbot@zytor.com using -f From: tip-bot for Laurence Oberman Message-ID: Cc: hpa@zytor.com, tglx@linutronix.de, linux-kernel@vger.kernel.org, mingo@kernel.org, loberman@redhat.com Reply-To: hpa@zytor.com, tglx@linutronix.de, linux-kernel@vger.kernel.org, loberman@redhat.com, mingo@kernel.org In-Reply-To: <1541079018-13953-1-git-send-email-loberman@redhat.com> References: <1541079018-13953-1-git-send-email-loberman@redhat.com> To: linux-tip-commits@vger.kernel.org Subject: [tip:core/core] watchdog/core: Add watchdog_thresh command line parameter Git-Commit-ID: 11295055526308ee71d82dc97f0a9ca2dd61c3b9 X-Mailer: tip-git-log-daemon Robot-ID: Robot-Unsubscribe: Contact to get blacklisted from these emails MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset=UTF-8 Content-Disposition: inline X-Spam-Status: No, score=-2.9 required=5.0 tests=ALL_TRUSTED,BAYES_00, T_DATE_IN_FUTURE_96_Q autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on terminus.zytor.com Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Commit-ID: 11295055526308ee71d82dc97f0a9ca2dd61c3b9 Gitweb: https://git.kernel.org/tip/11295055526308ee71d82dc97f0a9ca2dd61c3b9 Author: Laurence Oberman AuthorDate: Thu, 1 Nov 2018 09:30:18 -0400 Committer: Thomas Gleixner CommitDate: Thu, 1 Nov 2018 14:33:35 +0100 watchdog/core: Add watchdog_thresh command line parameter The hard and soft lockup detector threshold has a default value of 10 seconds which can only be changed via sysctl. During early boot lockup detection can trigger when noisy debugging emits a large amount of messages to the console, but there is no way to set a larger threshold on the kernel command line. The detector can only be completely disabled. Add a new watchdog_thresh= command line parameter to allow boot time control over the threshold. It works in the same way as the sysctl and affects both the soft and the hard lockup detectors. Signed-off-by: Laurence Oberman Signed-off-by: Thomas Gleixner Cc: rdunlap@infradead.org Cc: prarit@redhat.com Link: https://lkml.kernel.org/r/1541079018-13953-1-git-send-email-loberman@redhat.com --- Documentation/admin-guide/kernel-parameters.txt | 8 ++++++++ kernel/watchdog.c | 7 +++++++ 2 files changed, 15 insertions(+) diff --git a/Documentation/admin-guide/kernel-parameters.txt b/Documentation/admin-guide/kernel-parameters.txt index b90fe3b6bc6c..79b5b473001b 100644 --- a/Documentation/admin-guide/kernel-parameters.txt +++ b/Documentation/admin-guide/kernel-parameters.txt @@ -4957,6 +4957,14 @@ or other driver-specific files in the Documentation/watchdog/ directory. + watchdog_thresh= + [KNL] + Set the hard lockup detector stall duration + threshold in seconds. The soft lockup detector + threshold is set to twice the value. A value of 0 + disables both lockup detectors. Default is 10 + seconds. + workqueue.watchdog_thresh= If CONFIG_WQ_WATCHDOG is configured, workqueue can warn stall conditions and dump internal state to diff --git a/kernel/watchdog.c b/kernel/watchdog.c index 977918d5d350..8fbfda94a67b 100644 --- a/kernel/watchdog.c +++ b/kernel/watchdog.c @@ -199,6 +199,13 @@ static int __init nosoftlockup_setup(char *str) } __setup("nosoftlockup", nosoftlockup_setup); +static int __init watchdog_thresh_setup(char *str) +{ + get_option(&str, &watchdog_thresh); + return 1; +} +__setup("watchdog_thresh=", watchdog_thresh_setup); + #ifdef CONFIG_SMP int __read_mostly sysctl_softlockup_all_cpu_backtrace;