Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <1540971728-26789-1-git-send-email-mgottam@codeaurora.org>
 <3ff2c3dd-434d-960b-6806-f4bb8ec0d954@linaro.org> <3364115421e89c7710725c06b820f8c6@codeaurora.org>
In-Reply-To: <3364115421e89c7710725c06b820f8c6@codeaurora.org>
From:   Tomasz Figa <tfiga@chromium.org>
Date:   Thu, 1 Nov 2018 22:53:53 +0900
Message-ID: <CAAFQd5A+9GWmn4aD4D2JMf1e1m-6Dtc3xUdMZsf8fPtgi34QVQ@mail.gmail.com>
Subject: Re: [PATCH] media: venus: dynamic handling of bitrate
To:     mgottam@codeaurora.org
Cc:     Stanimir Varbanov <stanimir.varbanov@linaro.org>,
        Hans Verkuil <hverkuil@xs4all.nl>,
        Mauro Carvalho Chehab <mchehab@kernel.org>,
        Linux Media Mailing List <linux-media@vger.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        linux-arm-msm <linux-arm-msm@vger.kernel.org>,
        Alexandre Courbot <acourbot@chromium.org>,
        vgarodia@codeaurora.org
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Thu, Nov 1, 2018 at 10:01 PM <mgottam@codeaurora.org> wrote:
>
> On 2018-11-01 17:48, Stanimir Varbanov wrote:
> > Hi Malathi,
> >
> > Thanks for the patch!
> >
> > On 10/31/18 9:42 AM, Malathi Gottam wrote:
> >> Any request for a change in bitrate after both planes
> >> are streamed on is handled by setting the target bitrate
> >> property to hardware.
> >>
> >> Signed-off-by: Malathi Gottam <mgottam@codeaurora.org>
> >> ---
> >>  drivers/media/platform/qcom/venus/venc_ctrls.c | 11 +++++++++++
> >>  1 file changed, 11 insertions(+)
> >>
> >> diff --git a/drivers/media/platform/qcom/venus/venc_ctrls.c
> >> b/drivers/media/platform/qcom/venus/venc_ctrls.c
> >> index 45910172..54f310c 100644
> >> --- a/drivers/media/platform/qcom/venus/venc_ctrls.c
> >> +++ b/drivers/media/platform/qcom/venus/venc_ctrls.c
> >> @@ -79,7 +79,9 @@ static int venc_op_s_ctrl(struct v4l2_ctrl *ctrl)
> >>  {
> >>      struct venus_inst *inst = ctrl_to_inst(ctrl);
> >>      struct venc_controls *ctr = &inst->controls.enc;
> >> +    struct hfi_bitrate brate;
> >>      u32 bframes;
> >> +    u32 ptype;
> >>      int ret;
> >>
> >>      switch (ctrl->id) {
> >> @@ -88,6 +90,15 @@ static int venc_op_s_ctrl(struct v4l2_ctrl *ctrl)
> >>              break;
> >>      case V4L2_CID_MPEG_VIDEO_BITRATE:
> >>              ctr->bitrate = ctrl->val;
> >> +            if (inst->streamon_out && inst->streamon_cap) {
> >
> > Hmm, hfi_session_set_property already checks the instance state so I
> > don't think those checks are needed. Another thing is that we need to
> > take the instance mutex to check the instance state.
>
> Yes Stan, "hfi_session_set_property" this property check the instance
> state,
> but returns EINVAL if this is set at UNINIT instance state.
>
> Controls initialization happens much earlier than session init and
> instance init.
> So the instance is still in UNINIT state which causes failure while
> setting.
>
> Through this patch we try to meet the client request of changing bitrate
> only
> when both planes are streamed on.

Where does this requirement come from? It should be possible to set
the control at any time and it should apply to any encoding happening
after the control is set.

Best regards,
Tomasz