Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH] media: venus: dynamic handling of bitrate
To:     Tomasz Figa <tfiga@chromium.org>, vgarodia@codeaurora.org
Cc:     mgottam@codeaurora.org,
        Stanimir Varbanov <stanimir.varbanov@linaro.org>,
        Hans Verkuil <hverkuil@xs4all.nl>,
        Mauro Carvalho Chehab <mchehab@kernel.org>,
        Linux Media Mailing List <linux-media@vger.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        linux-arm-msm <linux-arm-msm@vger.kernel.org>,
        Alexandre Courbot <acourbot@chromium.org>,
        linux-media-owner@vger.kernel.org
References: <1540971728-26789-1-git-send-email-mgottam@codeaurora.org>
 <3ff2c3dd-434d-960b-6806-f4bb8ec0d954@linaro.org>
 <3364115421e89c7710725c06b820f8c6@codeaurora.org>
 <CAAFQd5A+9GWmn4aD4D2JMf1e1m-6Dtc3xUdMZsf8fPtgi34QVQ@mail.gmail.com>
 <ba1453b6868e97b96e0345129153b819@codeaurora.org>
 <CAAFQd5DuEqTiJbp5wR=_V0zVkVXTJPuMxDaJoTYFvVYfUA8U8g@mail.gmail.com>
From:   Stanimir Varbanov <stanimir.varbanov@linaro.org>
Message-ID: <19a08bd3-4e4c-56d2-6df2-54c3d91af4f3@linaro.org>
Date:   Thu, 1 Nov 2018 17:03:13 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101
 Thunderbird/60.2.1
MIME-Version: 1.0
In-Reply-To: <CAAFQd5DuEqTiJbp5wR=_V0zVkVXTJPuMxDaJoTYFvVYfUA8U8g@mail.gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


On 11/1/18 4:31 PM, Tomasz Figa wrote:
> On Thu, Nov 1, 2018 at 11:23 PM Vikash Garodia <vgarodia@codeaurora.org> wrote:
>>
>> On 2018-11-01 19:23, Tomasz Figa wrote:
>>> On Thu, Nov 1, 2018 at 10:01 PM <mgottam@codeaurora.org> wrote:
>>>>
>>>> On 2018-11-01 17:48, Stanimir Varbanov wrote:
>>>>> Hi Malathi,
>>>>>
>>>>> Thanks for the patch!
>>>>>
>>>>> On 10/31/18 9:42 AM, Malathi Gottam wrote:
>>>>>> Any request for a change in bitrate after both planes
>>>>>> are streamed on is handled by setting the target bitrate
>>>>>> property to hardware.
>>>>>>
>>>>>> Signed-off-by: Malathi Gottam <mgottam@codeaurora.org>
>>>>>> ---
>>>>>>  drivers/media/platform/qcom/venus/venc_ctrls.c | 11 +++++++++++
>>>>>>  1 file changed, 11 insertions(+)
>>>>>>
>>>>>> diff --git a/drivers/media/platform/qcom/venus/venc_ctrls.c
>>>>>> b/drivers/media/platform/qcom/venus/venc_ctrls.c
>>>>>> index 45910172..54f310c 100644
>>>>>> --- a/drivers/media/platform/qcom/venus/venc_ctrls.c
>>>>>> +++ b/drivers/media/platform/qcom/venus/venc_ctrls.c
>>>>>> @@ -79,7 +79,9 @@ static int venc_op_s_ctrl(struct v4l2_ctrl *ctrl)
>>>>>>  {
>>>>>>      struct venus_inst *inst = ctrl_to_inst(ctrl);
>>>>>>      struct venc_controls *ctr = &inst->controls.enc;
>>>>>> +    struct hfi_bitrate brate;
>>>>>>      u32 bframes;
>>>>>> +    u32 ptype;
>>>>>>      int ret;
>>>>>>
>>>>>>      switch (ctrl->id) {
>>>>>> @@ -88,6 +90,15 @@ static int venc_op_s_ctrl(struct v4l2_ctrl *ctrl)
>>>>>>              break;
>>>>>>      case V4L2_CID_MPEG_VIDEO_BITRATE:
>>>>>>              ctr->bitrate = ctrl->val;
>>>>>> +            if (inst->streamon_out && inst->streamon_cap) {
>>>>>
>>>>> Hmm, hfi_session_set_property already checks the instance state so I
>>>>> don't think those checks are needed. Another thing is that we need to
>>>>> take the instance mutex to check the instance state.
>>>>
>>>> Yes Stan, "hfi_session_set_property" this property check the instance
>>>> state,
>>>> but returns EINVAL if this is set at UNINIT instance state.
>>>>
>>>> Controls initialization happens much earlier than session init and
>>>> instance init.
>>>> So the instance is still in UNINIT state which causes failure while
>>>> setting.
>>>>
>>>> Through this patch we try to meet the client request of changing
>>>> bitrate
>>>> only
>>>> when both planes are streamed on.
>>>
>>> Where does this requirement come from? It should be possible to set
>>> the control at any time and it should apply to any encoding happening
>>> after the control is set.
>>>
>> With the patch, now video driver will set the control whenever client
>> sets
>> and will apply to encoder.
> 
> That's good, thanks for clarifying. I guess I misunderstood Malathi's comment.

OK, just wonder about locking when we check streamon_out/cap flags?

-- 
regards,
Stan