Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Thu, 1 Nov 2018 16:34:18 +0100 (CET)
From:   Thomas Gleixner <tglx@linutronix.de>
To:     Daniel Vacek <neelx@redhat.com>
cc:     x86@kernel.org, Ingo Molnar <mingo@redhat.com>,
        Borislav Petkov <bp@alien8.de>,
        "H. Peter Anvin" <hpa@zytor.com>,
        LKML <linux-kernel@vger.kernel.org>,
        Peter Zijlstra <peterz@infradead.org>
Subject: Re: [PATCH] tsc: make calibration refinement more robust
In-Reply-To: <1541085133-32534-1-git-send-email-neelx@redhat.com>
Message-ID: <alpine.DEB.2.21.1811011630310.1642@nanos.tec.linutronix.de>
References: <1541085133-32534-1-git-send-email-neelx@redhat.com>
User-Agent: Alpine 2.21 (DEB 202 2017-01-01)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Daniel,

On Thu, 1 Nov 2018, Daniel Vacek wrote:

Please use 'x86/tsc:' as prefix. git log path/to/file usually gives you a
reasonable hint about prefixes.

> -#define MAX_RETRIES     5
> -#define SMI_TRESHOLD    50000
> +#define MAX_RETRIES	5
> +#define TSC_THRESHOLD	(tsc_khz >> 5)

This breaks pit_hpet_ptimer_calibrate_cpu() because at that point tsc_hkz is 0.

Thanks,

	tglx